[PR #2616] [MERGED] Simplify PublicKey trait #3184

New issue

Closed

opened 2026-03-16 11:29:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:29:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2616
Author: @djc
Created: 11/25/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @djc

Base: main ← Head: simplify-public-key

📝 Commits (8)

9f04cde proto: split public key backend code by backend
a0e25db proto: colocate Verifier impls with their types
b7d23af proto: move tests to the bottom of the module
40d0929 proto: move KEY impls closer to type definition
e49b216 proto: move sig0 KEY creation into KEY methods
3fae2c1 proto: move DNSKEY creation into constructor
c629f86 proto: move DS creation into constructor
befc408 proto: move key_tag() logic close to usage site

📊 Changes

15 files changed (+1287 additions, -1278 deletions)

View changed files

📝 bin/src/dnssec.rs (+5 -5)
📝 bin/src/hickory-dns.rs (+8 -4)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+8 -7)
📝 crates/proto/src/dnssec/mod.rs (+10 -10)
📝 crates/proto/src/dnssec/openssl.rs (+229 -6)
📝 crates/proto/src/dnssec/public_key.rs (+4 -544)
📝 crates/proto/src/dnssec/rdata/dnskey.rs (+25 -1)
📝 crates/proto/src/dnssec/rdata/ds.rs (+94 -3)
📝 crates/proto/src/dnssec/rdata/key.rs (+707 -658)
📝 crates/proto/src/dnssec/ring.rs (+178 -4)
📝 crates/proto/src/dnssec/signer.rs (+9 -7)
📝 crates/proto/src/dnssec/verifier.rs (+1 -21)
📝 crates/server/src/store/in_memory/authority.rs (+3 -3)
📝 tests/integration-tests/src/example_authority.rs (+3 -3)
📝 tests/integration-tests/tests/integration/client_future_tests.rs (+3 -2)

📄 Description

Extracts roughly the first half of my other, more ambitious PR:

#2605

All of this is pretty straightforward moving code around, so would be nice to get it merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2616 **Author:** [@djc](https://github.com/djc) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simplify-public-key` --- ### 📝 Commits (8) - [`9f04cde`](https://github.com/hickory-dns/hickory-dns/commit/9f04cded4f20d519dd6e712297e1ef26de8865ee) proto: split public key backend code by backend - [`a0e25db`](https://github.com/hickory-dns/hickory-dns/commit/a0e25db70bf96c0656bc6f10a110f6df99909ece) proto: colocate Verifier impls with their types - [`b7d23af`](https://github.com/hickory-dns/hickory-dns/commit/b7d23af821b8ac482f7a41b03187ae82f677af94) proto: move tests to the bottom of the module - [`40d0929`](https://github.com/hickory-dns/hickory-dns/commit/40d0929b78db6def4ead2faae7ad44f532576f76) proto: move KEY impls closer to type definition - [`e49b216`](https://github.com/hickory-dns/hickory-dns/commit/e49b216fe64e5027ac6ae1b9985dcbed97304253) proto: move sig0 KEY creation into KEY methods - [`3fae2c1`](https://github.com/hickory-dns/hickory-dns/commit/3fae2c14472a07cb962b74e5186d6c6b40e8d1b1) proto: move DNSKEY creation into constructor - [`c629f86`](https://github.com/hickory-dns/hickory-dns/commit/c629f8651a9027b2067bfff63a161e38692331e0) proto: move DS creation into constructor - [`befc408`](https://github.com/hickory-dns/hickory-dns/commit/befc40833b20da40adcf4129b4c3ca2abe15ce20) proto: move key_tag() logic close to usage site ### 📊 Changes **15 files changed** (+1287 additions, -1278 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+5 -5) 📝 `bin/src/hickory-dns.rs` (+8 -4) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+8 -7) 📝 `crates/proto/src/dnssec/mod.rs` (+10 -10) 📝 `crates/proto/src/dnssec/openssl.rs` (+229 -6) 📝 `crates/proto/src/dnssec/public_key.rs` (+4 -544) 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+25 -1) 📝 `crates/proto/src/dnssec/rdata/ds.rs` (+94 -3) 📝 `crates/proto/src/dnssec/rdata/key.rs` (+707 -658) 📝 `crates/proto/src/dnssec/ring.rs` (+178 -4) 📝 `crates/proto/src/dnssec/signer.rs` (+9 -7) 📝 `crates/proto/src/dnssec/verifier.rs` (+1 -21) 📝 `crates/server/src/store/in_memory/authority.rs` (+3 -3) 📝 `tests/integration-tests/src/example_authority.rs` (+3 -3) 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+3 -2) </details> ### 📄 Description Extracts roughly the first half of my other, more ambitious PR: * #2605 All of this is pretty straightforward moving code around, so would be nice to get it merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>