[PR #2594] [MERGED] Extend dig timeout in bad referral tests #3165

New issue

Closed

opened 2026-03-16 11:28:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:28:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2594
Author: @divergentdave
Created: 11/20/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @marcus0x62

Base: main ← Head: david/bad-referral-timeout

📝 Commits (1)

990ccc8 Extend dig timeout in bad referral tests

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios/bad_referral.rs (+1 -1)

📄 Description

I saw two test flakes from the resolver::dns::scenarios::bad_referral::v4_this_host conformance test yesterday, one in CI and one locally. This PR extends the dig timeout so that it's longer than Hickory DNS's timeout, similar to #2540. This should make this test more reliable until we have a new approach for handling this case, other than relying on a timeout (see #2545). I stress-tested this change overnight, and didn't see any more failures.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2594 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/20/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `david/bad-referral-timeout` --- ### 📝 Commits (1) - [`990ccc8`](https://github.com/hickory-dns/hickory-dns/commit/990ccc8d227a78eeaebc6ef9b8e7d988de403b69) Extend dig timeout in bad referral tests ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios/bad_referral.rs` (+1 -1) </details> ### 📄 Description I saw two test flakes from the `resolver::dns::scenarios::bad_referral::v4_this_host` conformance test yesterday, one in CI and one locally. This PR extends the dig timeout so that it's longer than Hickory DNS's timeout, similar to #2540. This should make this test more reliable until we have a new approach for handling this case, other than relying on a timeout (see #2545). I stress-tested this change overnight, and didn't see any more failures. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>