[PR #2589] [MERGED] Add support for ring-based RSA signing keys #3163

New issue

Closed

opened 2026-03-16 11:28:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:28:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2589
Author: @djc
Created: 11/19/2024
Status: ✅ Merged
Merged: 12/5/2024
Merged by: @djc

Base: main ← Head: ring-rsa

📝 Commits (10+)

3e9dee3 proto: split key_format module
a447686 proto: explicitly pick a signing backend in DNSSEC code
cb2db3f proto: add support for ring-based RSA signing keys
b673981 Switch integration tests to use ring for DNSSEC
c7aebce Avoid mandatory openssl dependencies
f792246 Remove unnecessary allow()
b7a94b5 tests: enable logging in SIG0 compatibility tests
23bd9b4 tests: fix paths to config files
05b24ed bin: fix Windows build failure
00fd40c ci: re-enable Windows

📊 Changes

24 files changed (+226 additions, -160 deletions)

View changed files

📝 .github/workflows/test.yml (+6 -3)
📝 Cargo.lock (+1 -1)
📝 bin/src/hickory-dns.rs (+7 -6)
📝 crates/proto/Cargo.toml (+0 -1)
➖ crates/proto/src/dnssec/key_format.rs (+0 -79)
📝 crates/proto/src/dnssec/mod.rs (+27 -16)
📝 crates/proto/src/dnssec/openssl.rs (+39 -0)
📝 crates/proto/src/dnssec/ring.rs (+96 -1)
📝 crates/proto/src/dnssec/signer.rs (+4 -2)
📝 crates/proto/src/rustls/mod.rs (+2 -1)
📝 crates/proto/src/rustls/tests.rs (+6 -8)
➕ crates/proto/tests/test-data/rsa-2048-private-key-1.pk8 (+0 -0)
➕ crates/proto/tests/test-data/rsa-2048-private-key-2.pk8 (+0 -0)
📝 justfile (+10 -3)
📝 tests/compatibility-tests/Cargo.toml (+2 -2)
➕ tests/compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.pk8 (+0 -0)
📝 tests/compatibility-tests/tests/conf/bind-example.conf (+5 -5)
📝 tests/compatibility-tests/tests/integration/sig0_tests.rs (+9 -21)
📝 tests/integration-tests/Cargo.toml (+0 -2)
📝 tests/integration-tests/src/example_authority.rs (+5 -4)

...and 4 more files

📄 Description

Switch tests to use ring by default and run CI on Windows.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2589 **Author:** [@djc](https://github.com/djc) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 12/5/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ring-rsa` --- ### 📝 Commits (10+) - [`3e9dee3`](https://github.com/hickory-dns/hickory-dns/commit/3e9dee309274be62daf06bdb3a1b98d18d1ebfaf) proto: split key_format module - [`a447686`](https://github.com/hickory-dns/hickory-dns/commit/a447686dfa901d8277b5d096f7991edffe917330) proto: explicitly pick a signing backend in DNSSEC code - [`cb2db3f`](https://github.com/hickory-dns/hickory-dns/commit/cb2db3fc06d7f831475ada7cc1fe7b6337727bcf) proto: add support for ring-based RSA signing keys - [`b673981`](https://github.com/hickory-dns/hickory-dns/commit/b673981228f637997dba456ed2179bf0f8862ad7) Switch integration tests to use ring for DNSSEC - [`c7aebce`](https://github.com/hickory-dns/hickory-dns/commit/c7aebce057959c76ddb5d70aeea91f6d618b35d5) Avoid mandatory openssl dependencies - [`f792246`](https://github.com/hickory-dns/hickory-dns/commit/f7922463d93ec95933915d095ffedafbc0293795) Remove unnecessary allow() - [`b7a94b5`](https://github.com/hickory-dns/hickory-dns/commit/b7a94b5e6b2b2799057cdcb4246f424cf3af9fc2) tests: enable logging in SIG0 compatibility tests - [`23bd9b4`](https://github.com/hickory-dns/hickory-dns/commit/23bd9b4e263cda3d41ca151ffb1113b2cdb6855c) tests: fix paths to config files - [`05b24ed`](https://github.com/hickory-dns/hickory-dns/commit/05b24edf8ee1750776ded6c6b15171b43dba30be) bin: fix Windows build failure - [`00fd40c`](https://github.com/hickory-dns/hickory-dns/commit/00fd40c54a47d5d3bed186b6124f21e3a964db05) ci: re-enable Windows ### 📊 Changes **24 files changed** (+226 additions, -160 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+6 -3) 📝 `Cargo.lock` (+1 -1) 📝 `bin/src/hickory-dns.rs` (+7 -6) 📝 `crates/proto/Cargo.toml` (+0 -1) ➖ `crates/proto/src/dnssec/key_format.rs` (+0 -79) 📝 `crates/proto/src/dnssec/mod.rs` (+27 -16) 📝 `crates/proto/src/dnssec/openssl.rs` (+39 -0) 📝 `crates/proto/src/dnssec/ring.rs` (+96 -1) 📝 `crates/proto/src/dnssec/signer.rs` (+4 -2) 📝 `crates/proto/src/rustls/mod.rs` (+2 -1) 📝 `crates/proto/src/rustls/tests.rs` (+6 -8) ➕ `crates/proto/tests/test-data/rsa-2048-private-key-1.pk8` (+0 -0) ➕ `crates/proto/tests/test-data/rsa-2048-private-key-2.pk8` (+0 -0) 📝 `justfile` (+10 -3) 📝 `tests/compatibility-tests/Cargo.toml` (+2 -2) ➕ `tests/compatibility-tests/tests/conf/Kupdate.example.com.+008+56935.pk8` (+0 -0) 📝 `tests/compatibility-tests/tests/conf/bind-example.conf` (+5 -5) 📝 `tests/compatibility-tests/tests/integration/sig0_tests.rs` (+9 -21) 📝 `tests/integration-tests/Cargo.toml` (+0 -2) 📝 `tests/integration-tests/src/example_authority.rs` (+5 -4) _...and 4 more files_ </details> ### 📄 Description Switch tests to use *ring* by default and run CI on Windows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>