[PR #2586] [MERGED] server: Fix compilation of recursor authority without DNSSEC #3156

New issue

Closed

opened 2026-03-16 11:28:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:28:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2586
Author: @divergentdave
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @djc

Base: main ← Head: david/server-recursor-no-dnssec

📝 Commits (5)

0622107 server: Use recursor/resolver features in cfg
bf376d5 server: recursor depends on hickory-resolver
6de3b18 server: Fix compilation with recursor, w/o DNSSEC
6fb761c Fix copied documentation
543a7e3 Disable implicit features

📊 Changes

8 files changed (+36 additions, -33 deletions)

View changed files

📝 crates/server/Cargo.toml (+2 -2)
📝 crates/server/src/authority/error.rs (+11 -11)
📝 crates/server/src/lib.rs (+2 -2)
📝 crates/server/src/store/forwarder/authority.rs (+1 -1)
📝 crates/server/src/store/forwarder/mod.rs (+1 -1)
📝 crates/server/src/store/recursor/authority.rs (+11 -6)
📝 crates/server/src/store/recursor/config.rs (+7 -9)
📝 crates/server/src/store/recursor/mod.rs (+1 -1)

📄 Description

This fixes compilation when the recursor feature is enabled, but not dnssec. I also updated all conditional compilation using the hickory-recursor and hickory-resolver features (from optional dependencies) to use recursor and resolver (which are explicitly defined) instead. This helps because the recursor code requires importing some common types from hickory-resolver.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2586 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/server-recursor-no-dnssec` --- ### 📝 Commits (5) - [`0622107`](https://github.com/hickory-dns/hickory-dns/commit/0622107e3c6f56773aec91d4864c69ffa9c71d3c) server: Use recursor/resolver features in cfg - [`bf376d5`](https://github.com/hickory-dns/hickory-dns/commit/bf376d58ec1206d14a416d201a0a7d7650c9f52c) server: recursor depends on hickory-resolver - [`6de3b18`](https://github.com/hickory-dns/hickory-dns/commit/6de3b1848a409e4c8c507f84309632d34977c550) server: Fix compilation with recursor, w/o DNSSEC - [`6fb761c`](https://github.com/hickory-dns/hickory-dns/commit/6fb761ccd9bb1f1d83e7777a00a25997c82cb272) Fix copied documentation - [`543a7e3`](https://github.com/hickory-dns/hickory-dns/commit/543a7e3b11d3a0d21fcb5c0721adee6c4cc460b8) Disable implicit features ### 📊 Changes **8 files changed** (+36 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/Cargo.toml` (+2 -2) 📝 `crates/server/src/authority/error.rs` (+11 -11) 📝 `crates/server/src/lib.rs` (+2 -2) 📝 `crates/server/src/store/forwarder/authority.rs` (+1 -1) 📝 `crates/server/src/store/forwarder/mod.rs` (+1 -1) 📝 `crates/server/src/store/recursor/authority.rs` (+11 -6) 📝 `crates/server/src/store/recursor/config.rs` (+7 -9) 📝 `crates/server/src/store/recursor/mod.rs` (+1 -1) </details> ### 📄 Description This fixes compilation when the `recursor` feature is enabled, but not `dnssec`. I also updated all conditional compilation using the `hickory-recursor` and `hickory-resolver` features (from optional dependencies) to use `recursor` and `resolver` (which are explicitly defined) instead. This helps because the recursor code requires importing some common types from `hickory-resolver`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>