mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[PR #2578] [CLOSED] Use larger fallback for max_payload() to accommodate larger nam server responses #3151
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#3151
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/2578
Author: @alexrenz
Created: 11/18/2024
Status: ❌ Closed
Base:
main← Head:patch-1📝 Commits (1)
1af7762Use larger default buffer size📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
crates/proto/src/op/message.rs(+1 -1)📄 Description
First off, let me say: thank you for developing the hickory set of crates 💛 These are super helpful!
We are using the hickory resolver in reqwest and ran into an issue in Azure, where hickory failed to resolve our URLs with warnings like this:
After some investigation, we figured out that Azure name servers were sending responses that were larger than 512 bytes to non-eDNS requests. In our understanding, this is a problem because hickory seems to use a receive buffer of 512 bytes for non-eDNS responses.
This PR increases the buffer size for non-eDNS responses to avoid this problem.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.