[PR #2573] [MERGED] Replace DnsResponse::new() constructor #3147

New issue

Closed

opened 2026-03-16 11:27:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:27:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2573
Author: @divergentdave
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/13/2024
Merged by: @djc

Base: main ← Head: david/dnsresponse-constructor

📝 Commits (1)

c34d68c Replace DnsResponse::new() constructor

📊 Changes

7 files changed (+27 additions, -32 deletions)

View changed files

📝 crates/proto/src/h2/h2_client_stream.rs (+1 -3)
📝 crates/proto/src/h3/h3_client_stream.rs (+1 -3)
📝 crates/proto/src/quic/quic_stream.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/tsig.rs (+1 -4)
📝 crates/proto/src/udp/udp_client_stream.rs (+10 -9)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+5 -7)
📝 crates/proto/src/xfer/dns_response.rs (+8 -5)

📄 Description

This removes the DnsResponse::new() constructor, and adds a new one, DnsResponse::from_buffer(), which parses a response message from a Vec<u8>. This is a follow-up to #2553.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2573 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/dnsresponse-constructor` --- ### 📝 Commits (1) - [`c34d68c`](https://github.com/hickory-dns/hickory-dns/commit/c34d68cb9335496b3d4f6fefa7c1ab1bbc69a34d) Replace DnsResponse::new() constructor ### 📊 Changes **7 files changed** (+27 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/h2/h2_client_stream.rs` (+1 -3) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+1 -3) 📝 `crates/proto/src/quic/quic_stream.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/tsig.rs` (+1 -4) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+10 -9) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+5 -7) 📝 `crates/proto/src/xfer/dns_response.rs` (+8 -5) </details> ### 📄 Description This removes the `DnsResponse::new()` constructor, and adds a new one, `DnsResponse::from_buffer()`, which parses a response message from a `Vec<u8>`. This is a follow-up to #2553. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>