[PR #2560] [MERGED] proto: account for fqdn in PartialEq impl #3137

New issue

Closed

opened 2026-03-16 11:27:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:27:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2560
Author: @djc
Created: 11/8/2024
Status: ✅ Merged
Merged: 12/10/2024
Merged by: @marcus0x62

Base: main ← Head: name-fqdn-eq

📝 Commits (5)

fdfd71e proto: minor cleanup
042ab3a Fix FQDN-vs-relative issues in Name implementation
0d3404e additional trait tests for name and lowername
79ae591 eq_ignore_root and eq_ignore_root_case methods for Name
36a2c46 unit test for resolver build_names

📊 Changes

36 files changed (+503 additions, -143 deletions)

View changed files

📝 bin/tests/integration/authority_battery/basic.rs (+1 -1)
📝 bin/tests/integration/named_tests.rs (+3 -2)
📝 bin/tests/integration/server_harness/mod.rs (+2 -2)
📝 bin/tests/integration/sqlite_tests.rs (+1 -1)
📝 bin/tests/integration/txt_tests.rs (+39 -33)
📝 crates/proto/src/dnssec/rdata/nsec.rs (+1 -1)
📝 crates/proto/src/dnssec/rdata/sig.rs (+1 -1)
📝 crates/proto/src/dnssec/tsig.rs (+3 -3)
📝 crates/proto/src/op/query.rs (+2 -2)
📝 crates/proto/src/rr/domain/name.rs (+337 -29)
📝 crates/proto/src/rr/lower_name.rs (+18 -0)
📝 crates/proto/src/rr/rdata/mx.rs (+1 -1)
📝 crates/proto/src/rr/rdata/name.rs (+2 -2)
📝 crates/proto/src/rr/rdata/naptr.rs (+1 -1)
📝 crates/proto/src/rr/rdata/soa.rs (+2 -2)
📝 crates/proto/src/rr/rdata/srv.rs (+1 -1)
📝 crates/proto/src/rr/rdata/svcb.rs (+2 -2)
📝 crates/proto/src/rr/record_data.rs (+7 -7)
📝 crates/proto/src/rr/resource.rs (+2 -2)
📝 crates/proto/src/serialize/binary/encoder.rs (+5 -5)

...and 16 more files

📄 Description

Fixes #2559.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2560 **Author:** [@djc](https://github.com/djc) **Created:** 11/8/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `name-fqdn-eq` --- ### 📝 Commits (5) - [`fdfd71e`](https://github.com/hickory-dns/hickory-dns/commit/fdfd71eb5019fa47f346f3ef2d017abe773ff6cf) proto: minor cleanup - [`042ab3a`](https://github.com/hickory-dns/hickory-dns/commit/042ab3adc7e0b764fa1ccf8a6b0279e5ee768351) Fix FQDN-vs-relative issues in Name implementation - [`0d3404e`](https://github.com/hickory-dns/hickory-dns/commit/0d3404ee1f8c397e304240e4dc72695eaea6d3fb) additional trait tests for name and lowername - [`79ae591`](https://github.com/hickory-dns/hickory-dns/commit/79ae591e2e58d9e17f06eb81bb86b9751f60c6a5) eq_ignore_root and eq_ignore_root_case methods for Name - [`36a2c46`](https://github.com/hickory-dns/hickory-dns/commit/36a2c46726abbcf8b5f4d7b4b7ec1f91d601cf12) unit test for resolver build_names ### 📊 Changes **36 files changed** (+503 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/basic.rs` (+1 -1) 📝 `bin/tests/integration/named_tests.rs` (+3 -2) 📝 `bin/tests/integration/server_harness/mod.rs` (+2 -2) 📝 `bin/tests/integration/sqlite_tests.rs` (+1 -1) 📝 `bin/tests/integration/txt_tests.rs` (+39 -33) 📝 `crates/proto/src/dnssec/rdata/nsec.rs` (+1 -1) 📝 `crates/proto/src/dnssec/rdata/sig.rs` (+1 -1) 📝 `crates/proto/src/dnssec/tsig.rs` (+3 -3) 📝 `crates/proto/src/op/query.rs` (+2 -2) 📝 `crates/proto/src/rr/domain/name.rs` (+337 -29) 📝 `crates/proto/src/rr/lower_name.rs` (+18 -0) 📝 `crates/proto/src/rr/rdata/mx.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/name.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/naptr.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/soa.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/srv.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/svcb.rs` (+2 -2) 📝 `crates/proto/src/rr/record_data.rs` (+7 -7) 📝 `crates/proto/src/rr/resource.rs` (+2 -2) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+5 -5) _...and 16 more files_ </details> ### 📄 Description Fixes #2559. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>