[PR #2553] [MERGED] Recursor: Create DnsResponse with consistent buffer #3132

New issue

Closed

opened 2026-03-16 11:27:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:27:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2553
Author: @divergentdave
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @djc

Base: main ← Head: david/recursor-dns-response-buffer

📝 Commits (1)

3f6ff18 Recursor: Create DnsResponse with consistent buffer

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+2 -2)

📄 Description

DnsResponse contains a Message and a buffer, which is supposed to be the encoding of that message. This changes one use of the new() constructor inside the recursor that was providing an inconsistent buffer. I don't think this was causing any issues, since the response object is consumed internally by the DnssecDnsHandle, relying on the Message, but I think it would be safest to keep them consistent, in case future changes start reading the buffer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2553 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/recursor-dns-response-buffer` --- ### 📝 Commits (1) - [`3f6ff18`](https://github.com/hickory-dns/hickory-dns/commit/3f6ff18b5659331ce12f406ae0fea9ace28fa8f4) Recursor: Create DnsResponse with consistent buffer ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+2 -2) </details> ### 📄 Description `DnsResponse` contains a `Message` and a buffer, which is supposed to be the encoding of that message. This changes one use of the `new()` constructor inside the recursor that was providing an inconsistent buffer. I don't think this was causing any issues, since the response object is consumed internally by the `DnssecDnsHandle`, relying on the `Message`, but I think it would be safest to keep them consistent, in case future changes start reading the buffer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>