[PR #2542] [MERGED] ci: don't build benchmarks, only check them #3121

New issue

Closed

opened 2026-03-16 11:26:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:26:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2542
Author: @djc
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @djc

Base: main ← Head: check-benches

📝 Commits (1)

e47379e ci: don't build benchmarks, only check them

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 justfile (+1 -1)

📄 Description

CI currently takes about 17 minutes for a full run, which feels long. The long pole appears to be the nightly job which builds benchmarks (but doesn't run them) in release mode. The goal here should be to make sure that they compile, so instead of running cargo bench --no-run we can run cargo check --benches which should be substantially faster.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2542 **Author:** [@djc](https://github.com/djc) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `check-benches` --- ### 📝 Commits (1) - [`e47379e`](https://github.com/hickory-dns/hickory-dns/commit/e47379e93406d466ce675347e6a1a636bbf139dd) ci: don't build benchmarks, only check them ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `justfile` (+1 -1) </details> ### 📄 Description CI currently takes about 17 minutes for a full run, which feels long. The long pole appears to be the nightly job which builds benchmarks (but doesn't run them) in release mode. The goal here should be to make sure that they compile, so instead of running `cargo bench --no-run` we can run `cargo check --benches` which should be substantially faster. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>