[PR #2537] [MERGED] Skip copying configuration file for dnslib #3119

New issue

Closed

opened 2026-03-16 11:26:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:26:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2537
Author: @divergentdave
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @marcus0x62

Base: main ← Head: david/skip-copying-dnslib-config

📝 Commits (1)

a695734 Skip copying configuration file for dnslib

📊 Changes

3 files changed (+21 additions, -18 deletions)

View changed files

📝 conformance/packages/dns-test/src/implementation.rs (+6 -6)
📝 conformance/packages/dns-test/src/name_server.rs (+12 -8)
📝 conformance/packages/dns-test/src/resolver.rs (+3 -4)

📄 Description

When running the new dnslib-based conformance test on my system, I get the following error message.

Error: "[dns-test-dnslib-76873-22] `[\"chmod\", \"666\", \"/dev/null\"]` failed"

I think this is likely due to my use of a rootless Docker installation, perhaps in combination with AppArmor hardening.

This PR fixes the issue by making conf_file_path() return an Option, so we can skip the copying and permissions changes, instead of using /dev/null in place of an actual file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2537 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `david/skip-copying-dnslib-config` --- ### 📝 Commits (1) - [`a695734`](https://github.com/hickory-dns/hickory-dns/commit/a695734088e282dd10b147a5c58e044c515f8a1b) Skip copying configuration file for dnslib ### 📊 Changes **3 files changed** (+21 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/implementation.rs` (+6 -6) 📝 `conformance/packages/dns-test/src/name_server.rs` (+12 -8) 📝 `conformance/packages/dns-test/src/resolver.rs` (+3 -4) </details> ### 📄 Description When running the new dnslib-based conformance test on my system, I get the following error message. ``` Error: "[dns-test-dnslib-76873-22] `[\"chmod\", \"666\", \"/dev/null\"]` failed" ``` I think this is likely due to my use of a rootless Docker installation, perhaps in combination with AppArmor hardening. This PR fixes the issue by making `conf_file_path()` return an `Option`, so we can skip the copying and permissions changes, instead of using `/dev/null` in place of an actual file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>