[PR #2528] [MERGED] tests: restore shorter timeout window in test #3113

New issue

Closed

opened 2026-03-16 11:25:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2528
Author: @djc
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @djc

Base: main ← Head: restore-quick-timeout

📝 Commits (1)

9ce0c73 tests: restore shorter timeout window in test

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 tests/integration-tests/tests/integration/client_tests.rs (+6 -1)

📄 Description

In f6b7c4be77, I refactored tests to use the async client API. Because of the large amount of changes, there was some amount of copy and pasting involved, and it looks like I missed the shorter timeout window that this test specified.

Restore the timeout duration to its previous value. @divergentdave can you test whether this solves the issue for you?

Fixes #2526 (hopefully).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2528 **Author:** [@djc](https://github.com/djc) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `restore-quick-timeout` --- ### 📝 Commits (1) - [`9ce0c73`](https://github.com/hickory-dns/hickory-dns/commit/9ce0c735c31fdde7064d1b41bfdf869e08109894) tests: restore shorter timeout window in test ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+6 -1) </details> ### 📄 Description In f6b7c4be7787327b52744f6c7a11da0386990d3f, I refactored tests to use the async client API. Because of the large amount of changes, there was some amount of copy and pasting involved, and it looks like I missed the shorter timeout window that this test specified. <img width="1225" alt="Screenshot 2024-10-24 at 09 43 23" src="https://github.com/user-attachments/assets/087d62c6-2099-470e-937c-423a53c79e46"> Restore the timeout duration to its previous value. @divergentdave can you test whether this solves the issue for you? Fixes #2526 (hopefully). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>