[PR #2529] [MERGED] Recursor builder tweaks #3111

New issue

Closed

opened 2026-03-16 11:25:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2529
Author: @djc
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @djc

Base: main ← Head: recursor-builder

📝 Commits (3)

e610d87 recursor: pass RecursorBuilder by value
a6bacb6 recursor: simplify trust anchor setup
4f0b2eb recursor: yield crate::Error instead of ResolveError

📊 Changes

3 files changed (+35 additions, -46 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+30 -40)
📝 crates/recursor/src/recursor_dns_handle.rs (+3 -4)
📝 crates/server/src/store/recursor/authority.rs (+2 -2)

📄 Description

From reviewing #2524. Happy to rebase on top of that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2529 **Author:** [@djc](https://github.com/djc) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `recursor-builder` --- ### 📝 Commits (3) - [`e610d87`](https://github.com/hickory-dns/hickory-dns/commit/e610d875b0723532171e83c821dc05173cf83e65) recursor: pass RecursorBuilder by value - [`a6bacb6`](https://github.com/hickory-dns/hickory-dns/commit/a6bacb64ed4bdcd1185b3b88a32940caf7c9249f) recursor: simplify trust anchor setup - [`4f0b2eb`](https://github.com/hickory-dns/hickory-dns/commit/4f0b2eb470348303e27370f26dfb749b352071ea) recursor: yield crate::Error instead of ResolveError ### 📊 Changes **3 files changed** (+35 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+30 -40) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+3 -4) 📝 `crates/server/src/store/recursor/authority.rs` (+2 -2) </details> ### 📄 Description From reviewing #2524. Happy to rebase on top of that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>