[PR #2521] [MERGED] client: remove synchronous API #3103

New issue

Closed

opened 2026-03-16 11:25:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2521
Author: @djc
Created: 10/22/2024
Status: ✅ Merged
Merged: 10/23/2024
Merged by: @djc

Base: main ← Head: async-tsign

📝 Commits (9)

5a4ac1c tests: fix warnings in disabled code, hoist guards
fdfdbe7 tests: use async client for tsig compatibility tests
3bdec08 tests: use async client for zone transfer compatibility tests
5928fef tests: use async client for client integration tests
eb58e06 tests: use async for server future integration tests
2005c3e client: remove synchronous client API
7bc6071 client: rename Async{,Dnssec}Client to remove Async prefix
962a025 client: rename modules to match type names
08a4706 ci: allow jobs to continue on error

📊 Changes

32 files changed (+1314 additions, -2666 deletions)

View changed files

📝 .github/workflows/test.yml (+9 -0)
📝 bin/benches/comparison_benches.rs (+3 -3)
📝 bin/tests/integration/named_https_tests.rs (+1 -1)
📝 bin/tests/integration/named_quic_tests.rs (+1 -1)
📝 bin/tests/integration/named_rustls_tests.rs (+3 -3)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+3 -3)
📝 bin/tests/integration/named_tests.rs (+21 -21)
📝 bin/tests/integration/server_harness/mod.rs (+3 -11)
➖ crates/client/src/client/async_client.rs (+0 -1120)
📝 crates/client/src/client/client.rs (+790 -305)
➖ crates/client/src/client/client_connection.rs (+0 -30)
📝 crates/client/src/client/dnssec_client.rs (+10 -10)
📝 crates/client/src/client/mod.rs (+6 -12)
➖ crates/client/src/h2_client_connection.rs (+0 -171)
📝 crates/client/src/lib.rs (+18 -163)
➖ crates/client/src/multicast/mdns_client_connection.rs (+0 -69)
➖ crates/client/src/multicast/mod.rs (+0 -11)
➖ crates/client/src/tcp/mod.rs (+0 -20)
➖ crates/client/src/tcp/tcp_client_connection.rs (+0 -109)
➖ crates/client/src/udp/mod.rs (+0 -20)

...and 12 more files

📄 Description

Port remaining test users of the synchronous API, then removes the synchronous client API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2521 **Author:** [@djc](https://github.com/djc) **Created:** 10/22/2024 **Status:** ✅ Merged **Merged:** 10/23/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `async-tsign` --- ### 📝 Commits (9) - [`5a4ac1c`](https://github.com/hickory-dns/hickory-dns/commit/5a4ac1cfd56f1df8d85d7321b3e627aef8cc34f3) tests: fix warnings in disabled code, hoist guards - [`fdfdbe7`](https://github.com/hickory-dns/hickory-dns/commit/fdfdbe7f37430f0db80abce9af79a5e75aae2284) tests: use async client for tsig compatibility tests - [`3bdec08`](https://github.com/hickory-dns/hickory-dns/commit/3bdec08fb83c435818c43fbb32ff4f69127687b6) tests: use async client for zone transfer compatibility tests - [`5928fef`](https://github.com/hickory-dns/hickory-dns/commit/5928fef3303ab855fad45f1d74fded6ac4e5e9d8) tests: use async client for client integration tests - [`eb58e06`](https://github.com/hickory-dns/hickory-dns/commit/eb58e06314ec9f065a3c86682b56af6aae16722c) tests: use async for server future integration tests - [`2005c3e`](https://github.com/hickory-dns/hickory-dns/commit/2005c3e05d5c77712b1480996eaa692a618708f4) client: remove synchronous client API - [`7bc6071`](https://github.com/hickory-dns/hickory-dns/commit/7bc607137543e73438f69b326bfed09731c9dc9e) client: rename Async{,Dnssec}Client to remove Async prefix - [`962a025`](https://github.com/hickory-dns/hickory-dns/commit/962a02549eb72097bb70859d9dcb198b0ab4fe9b) client: rename modules to match type names - [`08a4706`](https://github.com/hickory-dns/hickory-dns/commit/08a47063c1a0178376ef5abc33f23e8b90fe6655) ci: allow jobs to continue on error ### 📊 Changes **32 files changed** (+1314 additions, -2666 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+9 -0) 📝 `bin/benches/comparison_benches.rs` (+3 -3) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_quic_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_rustls_tests.rs` (+3 -3) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+3 -3) 📝 `bin/tests/integration/named_tests.rs` (+21 -21) 📝 `bin/tests/integration/server_harness/mod.rs` (+3 -11) ➖ `crates/client/src/client/async_client.rs` (+0 -1120) 📝 `crates/client/src/client/client.rs` (+790 -305) ➖ `crates/client/src/client/client_connection.rs` (+0 -30) 📝 `crates/client/src/client/dnssec_client.rs` (+10 -10) 📝 `crates/client/src/client/mod.rs` (+6 -12) ➖ `crates/client/src/h2_client_connection.rs` (+0 -171) 📝 `crates/client/src/lib.rs` (+18 -163) ➖ `crates/client/src/multicast/mdns_client_connection.rs` (+0 -69) ➖ `crates/client/src/multicast/mod.rs` (+0 -11) ➖ `crates/client/src/tcp/mod.rs` (+0 -20) ➖ `crates/client/src/tcp/tcp_client_connection.rs` (+0 -109) ➖ `crates/client/src/udp/mod.rs` (+0 -20) _...and 12 more files_ </details> ### 📄 Description Port remaining test users of the synchronous API, then removes the synchronous client API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>