[PR #2509] [MERGED] Replace TryParseIp trait with IntoName::to_ip() #3099

New issue

Closed

opened 2026-03-16 11:25:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2509
Author: @djc
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/19/2024
Merged by: @djc

Base: main ← Head: as-ip

📝 Commits (1)

6007aaa Replace TryParseIp trait with IntoName::to_ip()

📊 Changes

10 files changed (+57 additions, -91 deletions)

View changed files

📝 crates/proto/src/rr/domain/mod.rs (+0 -2)
📝 crates/proto/src/rr/domain/name.rs (+19 -0)
➖ crates/proto/src/rr/domain/try_parse_ip.rs (+0 -66)
📝 crates/proto/src/rr/mod.rs (+1 -1)
📝 crates/proto/src/rr/record_data.rs (+26 -1)
📝 crates/resolver/examples/global_resolver.rs (+2 -4)
📝 crates/resolver/src/async_resolver.rs (+5 -10)
📝 crates/resolver/src/hosts.rs (+2 -4)
📝 crates/resolver/src/lib.rs (+1 -1)
📝 crates/resolver/src/resolver.rs (+1 -2)

📄 Description

I randomly bumped into the TryParseIp trait which seems like unnecessary complexity. It is always used in conjunction with IntoName so adding it as a method on that trait seemed like a simpler way to do things.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2509 **Author:** [@djc](https://github.com/djc) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/19/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `as-ip` --- ### 📝 Commits (1) - [`6007aaa`](https://github.com/hickory-dns/hickory-dns/commit/6007aaaf23507908667905d08fc1824b8dbfc9ec) Replace TryParseIp trait with IntoName::to_ip() ### 📊 Changes **10 files changed** (+57 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/domain/mod.rs` (+0 -2) 📝 `crates/proto/src/rr/domain/name.rs` (+19 -0) ➖ `crates/proto/src/rr/domain/try_parse_ip.rs` (+0 -66) 📝 `crates/proto/src/rr/mod.rs` (+1 -1) 📝 `crates/proto/src/rr/record_data.rs` (+26 -1) 📝 `crates/resolver/examples/global_resolver.rs` (+2 -4) 📝 `crates/resolver/src/async_resolver.rs` (+5 -10) 📝 `crates/resolver/src/hosts.rs` (+2 -4) 📝 `crates/resolver/src/lib.rs` (+1 -1) 📝 `crates/resolver/src/resolver.rs` (+1 -2) </details> ### 📄 Description I randomly bumped into the `TryParseIp` trait which seems like unnecessary complexity. It is always used in conjunction with `IntoName` so adding it as a method on that trait seemed like a simpler way to do things. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>