[PR #2515] [MERGED] Kill the sync Resolver #3098

New issue

Closed

opened 2026-03-16 11:25:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:25:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2515
Author: @djc
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/20/2024
Merged by: @djc

Base: main ← Head: no-sync-resolver

📝 Commits (9)

922491a util: use async resolver for get-root-ksks
199eb58 resolver: kill the (sync) Resolver
b4ec64a resolver: remove deprecated type alias
12000a6 resolver: don't use extern crate for hickory_proto
c539b10 resolver: avoid extern crate
0c8a314 resolver: keep use statements together with source modules
881c81f resolver: rename {Tokio,}AsyncResolver to drop the Async
a1e9635 resolver: add aliases for AsyncResolver/TokioAsyncResolver
c78f2bc resolver: rename async_resolver module to resolver

📊 Changes

30 files changed (+1243 additions, -1505 deletions)

View changed files

📝 crates/async-std-resolver/src/lib.rs (+4 -4)
📝 crates/resolver/examples/custom_provider.rs (+4 -4)
📝 crates/resolver/examples/flush_cache.rs (+3 -3)
📝 crates/resolver/examples/global_resolver.rs (+5 -5)
📝 crates/resolver/examples/multithreaded_runtime.rs (+2 -2)
➖ crates/resolver/src/async_resolver.rs (+0 -1219)
📝 crates/resolver/src/caching_client.rs (+3 -3)
📝 crates/resolver/src/config.rs (+4 -2)
📝 crates/resolver/src/dns_lru.rs (+6 -6)
📝 crates/resolver/src/h2.rs (+6 -6)
📝 crates/resolver/src/h3.rs (+5 -5)
📝 crates/resolver/src/hosts.rs (+4 -4)
📝 crates/resolver/src/lib.rs (+27 -68)
📝 crates/resolver/src/lookup.rs (+5 -5)
📝 crates/resolver/src/lookup_ip.rs (+6 -6)
📝 crates/resolver/src/name_server/connection_provider.rs (+13 -12)
📝 crates/resolver/src/name_server/name_server.rs (+4 -4)
📝 crates/resolver/src/name_server/name_server_pool.rs (+7 -7)
📝 crates/resolver/src/name_server/name_server_state.rs (+1 -1)
📝 crates/resolver/src/quic.rs (+4 -4)

...and 10 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2515 **Author:** [@djc](https://github.com/djc) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/20/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `no-sync-resolver` --- ### 📝 Commits (9) - [`922491a`](https://github.com/hickory-dns/hickory-dns/commit/922491a7882f9271294970ec3aa655e74b3be836) util: use async resolver for get-root-ksks - [`199eb58`](https://github.com/hickory-dns/hickory-dns/commit/199eb58dbc37632f792a456e843bb27d2bead9e9) resolver: kill the (sync) Resolver - [`b4ec64a`](https://github.com/hickory-dns/hickory-dns/commit/b4ec64a2c089f9a146bc3e925c97711240ea5577) resolver: remove deprecated type alias - [`12000a6`](https://github.com/hickory-dns/hickory-dns/commit/12000a6688fecab51bcb3e333cdb8c561a25e44e) resolver: don't use extern crate for hickory_proto - [`c539b10`](https://github.com/hickory-dns/hickory-dns/commit/c539b103294d82197d9a9c537ac843e164850698) resolver: avoid extern crate - [`0c8a314`](https://github.com/hickory-dns/hickory-dns/commit/0c8a314ac56209c7d4d0379c1cac25e5426bc44b) resolver: keep use statements together with source modules - [`881c81f`](https://github.com/hickory-dns/hickory-dns/commit/881c81ff057e67cde7bbc29660cbc5a7d3bb276e) resolver: rename {Tokio,}AsyncResolver to drop the Async - [`a1e9635`](https://github.com/hickory-dns/hickory-dns/commit/a1e9635cab00b767959dcc1bf2a5553de41b4c8d) resolver: add aliases for AsyncResolver/TokioAsyncResolver - [`c78f2bc`](https://github.com/hickory-dns/hickory-dns/commit/c78f2bc3f4673778ec4373bd24436b0536bd2b4b) resolver: rename async_resolver module to resolver ### 📊 Changes **30 files changed** (+1243 additions, -1505 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/src/lib.rs` (+4 -4) 📝 `crates/resolver/examples/custom_provider.rs` (+4 -4) 📝 `crates/resolver/examples/flush_cache.rs` (+3 -3) 📝 `crates/resolver/examples/global_resolver.rs` (+5 -5) 📝 `crates/resolver/examples/multithreaded_runtime.rs` (+2 -2) ➖ `crates/resolver/src/async_resolver.rs` (+0 -1219) 📝 `crates/resolver/src/caching_client.rs` (+3 -3) 📝 `crates/resolver/src/config.rs` (+4 -2) 📝 `crates/resolver/src/dns_lru.rs` (+6 -6) 📝 `crates/resolver/src/h2.rs` (+6 -6) 📝 `crates/resolver/src/h3.rs` (+5 -5) 📝 `crates/resolver/src/hosts.rs` (+4 -4) 📝 `crates/resolver/src/lib.rs` (+27 -68) 📝 `crates/resolver/src/lookup.rs` (+5 -5) 📝 `crates/resolver/src/lookup_ip.rs` (+6 -6) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+13 -12) 📝 `crates/resolver/src/name_server/name_server.rs` (+4 -4) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+7 -7) 📝 `crates/resolver/src/name_server/name_server_state.rs` (+1 -1) 📝 `crates/resolver/src/quic.rs` (+4 -4) _...and 10 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>