[PR #2504] [MERGED] Docs: resolver no longer returns background future #3091

New issue

Closed

opened 2026-03-16 11:24:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:24:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2504
Author: @divergentdave
Created: 10/10/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @djc

Base: main ← Head: david/fix-async-resolver-docs

📝 Commits (1)

e6c3fb7 Docs: resolver no longer returns background future

📊 Changes

3 files changed (+7 additions, -56 deletions)

View changed files

📝 crates/async-std-resolver/src/lib.rs (+0 -7)
📝 crates/resolver/src/async_resolver.rs (+7 -39)
📝 crates/resolver/src/lib.rs (+0 -10)

📄 Description

This updates some documentation in the resolver crates to remove outdated mentions of background futures being returned by constructors. The async resolver now spawns a background task for each lookup using its runtime provider, see ConnectionFuture in crates/resolver/src/name_server/connection_provider.rs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2504 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/fix-async-resolver-docs` --- ### 📝 Commits (1) - [`e6c3fb7`](https://github.com/hickory-dns/hickory-dns/commit/e6c3fb7bed10de3384707923a3ebb9797370367c) Docs: resolver no longer returns background future ### 📊 Changes **3 files changed** (+7 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/src/lib.rs` (+0 -7) 📝 `crates/resolver/src/async_resolver.rs` (+7 -39) 📝 `crates/resolver/src/lib.rs` (+0 -10) </details> ### 📄 Description This updates some documentation in the resolver crates to remove outdated mentions of background futures being returned by constructors. The async resolver now spawns a background task for each lookup using its runtime provider, see `ConnectionFuture` in `crates/resolver/src/name_server/connection_provider.rs`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>