[PR #2482] [MERGED] Remove unneeded vecs in ForwardNSData and wrap in an Arc #3079

New issue

Closed

opened 2026-03-16 11:23:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2482
Author: @marcus0x62
Created: 9/27/2024
Status: ✅ Merged
Merged: 9/27/2024
Merged by: @marcus0x62

Base: main ← Head: forwardns_fix

📝 Commits (2)

2603d10 Remove unnecessary Vecs in ForwardNSData; wrap in Arc
507d994 Inline format arguments

📊 Changes

4 files changed (+14 additions, -17 deletions)

View changed files

📝 crates/proto/src/error.rs (+5 -5)
📝 crates/recursor/src/error.rs (+2 -2)
📝 crates/recursor/src/recursor_dns_handle.rs (+6 -9)
📝 crates/resolver/src/caching_client.rs (+1 -1)

📄 Description

This removes some unneeded Vecs in the ForwardNSData structure and wraps the overall structure in an Arc. It doesn't eliminate the need to clone the ForwardNSData structure when promoting from ProtoError to RecursorError, but the Arc should make the clone a bit less expensive.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2482 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 9/27/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `forwardns_fix` --- ### 📝 Commits (2) - [`2603d10`](https://github.com/hickory-dns/hickory-dns/commit/2603d1030cd1f32f7440b12ca2eabb65541d4e13) Remove unnecessary Vecs in ForwardNSData; wrap in Arc - [`507d994`](https://github.com/hickory-dns/hickory-dns/commit/507d9940b14f594eabc0d906c1345d4f84dba0c5) Inline format arguments ### 📊 Changes **4 files changed** (+14 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/error.rs` (+5 -5) 📝 `crates/recursor/src/error.rs` (+2 -2) 📝 `crates/recursor/src/recursor_dns_handle.rs` (+6 -9) 📝 `crates/resolver/src/caching_client.rs` (+1 -1) </details> ### 📄 Description This removes some unneeded Vecs in the ForwardNSData structure and wraps the overall structure in an Arc. It doesn't eliminate the need to clone the ForwardNSData structure when promoting from ProtoError to RecursorError, but the Arc should make the clone a bit less expensive. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>