[PR #2485] [MERGED] Remove workaround in clippy justfile target #3076

Closed
opened 2026-03-16 11:23:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2485
Author: @divergentdave
Created: 9/30/2024
Status: Merged
Merged: 10/1/2024
Merged by: @djc

Base: mainHead: david/remove-clippy-workaround


📝 Commits (1)

  • 3aa92a3 Remove workaround in clippy justfile target

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 justfile (+0 -1)

📄 Description

This removes a workaround in just clippy. Previously this would touch every source file, in order to ensure cargo clippy would process the source tree even if cargo check had just run. This is no longer an issue, as the caching issue across cargo check and cargo clippy has been resolved, and clippy can now print out lint messages cached from a previous run.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2485 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/remove-clippy-workaround` --- ### 📝 Commits (1) - [`3aa92a3`](https://github.com/hickory-dns/hickory-dns/commit/3aa92a35ff79b6ce516ca33fd8cc141030f392d3) Remove workaround in clippy justfile target ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `justfile` (+0 -1) </details> ### 📄 Description This removes a workaround in `just clippy`. Previously this would touch every source file, in order to ensure `cargo clippy` would process the source tree even if `cargo check` had just run. This is no longer an issue, as the caching issue across `cargo check` and `cargo clippy` has been resolved, and clippy can now print out lint messages cached from a previous run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:23:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3076
No description provided.