[PR #2480] [MERGED] Config tweaks #3072

New issue

Closed

opened 2026-03-16 11:23:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2480
Author: @djc
Created: 9/27/2024
Status: ✅ Merged
Merged: 9/29/2024
Merged by: @djc

Base: main ← Head: config-tweaks

📝 Commits (8)

c7a2f5b server: fix inconsistent conditional in integration test
aacad29 server: move NxProofKind out of config module
1ffe1ff Move Protocol from resolver to proto
1000728 server: remove Protocol enum in favor of proto type
33a3e95 Move server integration tests into bin crate
f9bd294 Move config from server to bin crate
7b030d4 bin: remove get_() prefixes from config getters
401cf29 bin: derive Default for dnssec enums

📊 Changes

58 files changed (+412 additions, -452 deletions)

View changed files

📝 Cargo.lock (+6 -0)
📝 bin/Cargo.toml (+10 -1)
📝 bin/src/dnssec.rs (+21 -54)
📝 bin/src/hickory-dns.rs (+37 -41)
📝 bin/src/lib.rs (+37 -41)
📝 bin/tests/integration/authority_battery/basic.rs (+5 -4)
📝 bin/tests/integration/authority_battery/dnssec.rs (+6 -6)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+7 -6)
📝 bin/tests/integration/authority_battery/mod.rs (+0 -0)
📝 bin/tests/integration/config_tests.rs (+45 -49)
📝 bin/tests/integration/forwarder.rs (+1 -1)
📝 bin/tests/integration/in_memory.rs (+1 -1)
📝 bin/tests/integration/main.rs (+10 -0)
📝 bin/tests/integration/named_https_tests.rs (+5 -5)
📝 bin/tests/integration/named_quic_tests.rs (+4 -4)
📝 bin/tests/integration/named_rustls_tests.rs (+3 -5)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+4 -5)
📝 bin/tests/integration/named_tests.rs (+5 -6)
📝 bin/tests/integration/server_harness/mod.rs (+3 -1)
📝 bin/tests/integration/sqlite_tests.rs (+0 -0)

...and 38 more files

📄 Description

Follow-up from #2470 that also tries to clean up a bunch of stuff.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2480 **Author:** [@djc](https://github.com/djc) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 9/29/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `config-tweaks` --- ### 📝 Commits (8) - [`c7a2f5b`](https://github.com/hickory-dns/hickory-dns/commit/c7a2f5bc3e2d08403662fae3ce19009ef9685806) server: fix inconsistent conditional in integration test - [`aacad29`](https://github.com/hickory-dns/hickory-dns/commit/aacad29ad40122ca4d27d762817f68ef67d8db34) server: move NxProofKind out of config module - [`1ffe1ff`](https://github.com/hickory-dns/hickory-dns/commit/1ffe1ff221f9d3f2a6d2e24c0523e16d3685091d) Move Protocol from resolver to proto - [`1000728`](https://github.com/hickory-dns/hickory-dns/commit/10007286c4ac78d308b9b64fbb040bc7794ccdca) server: remove Protocol enum in favor of proto type - [`33a3e95`](https://github.com/hickory-dns/hickory-dns/commit/33a3e9511f165c39514ed958b274f062560d5ea8) Move server integration tests into bin crate - [`f9bd294`](https://github.com/hickory-dns/hickory-dns/commit/f9bd294c3817e4f1f1371bd80cfce6a1fa7a6844) Move config from server to bin crate - [`7b030d4`](https://github.com/hickory-dns/hickory-dns/commit/7b030d4324117ea1ae3478ab9fbca5061c4f9385) bin: remove get_() prefixes from config getters - [`401cf29`](https://github.com/hickory-dns/hickory-dns/commit/401cf2922d38b612d5887042091695432d669238) bin: derive Default for dnssec enums ### 📊 Changes **58 files changed** (+412 additions, -452 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+6 -0) 📝 `bin/Cargo.toml` (+10 -1) 📝 `bin/src/dnssec.rs` (+21 -54) 📝 `bin/src/hickory-dns.rs` (+37 -41) 📝 `bin/src/lib.rs` (+37 -41) 📝 `bin/tests/integration/authority_battery/basic.rs` (+5 -4) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+6 -6) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+7 -6) 📝 `bin/tests/integration/authority_battery/mod.rs` (+0 -0) 📝 `bin/tests/integration/config_tests.rs` (+45 -49) 📝 `bin/tests/integration/forwarder.rs` (+1 -1) 📝 `bin/tests/integration/in_memory.rs` (+1 -1) 📝 `bin/tests/integration/main.rs` (+10 -0) 📝 `bin/tests/integration/named_https_tests.rs` (+5 -5) 📝 `bin/tests/integration/named_quic_tests.rs` (+4 -4) 📝 `bin/tests/integration/named_rustls_tests.rs` (+3 -5) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+4 -5) 📝 `bin/tests/integration/named_tests.rs` (+5 -6) 📝 `bin/tests/integration/server_harness/mod.rs` (+3 -1) 📝 `bin/tests/integration/sqlite_tests.rs` (+0 -0) _...and 38 more files_ </details> ### 📄 Description Follow-up from #2470 that also tries to clean up a bunch of stuff. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>