[PR #2476] [MERGED] fix compilation failed #3070

New issue

Closed

opened 2026-03-16 11:23:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2476
Author: @hingbong
Created: 9/26/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @djc

Base: main ← Head: patch-1

📝 Commits (1)

e817935 fix compilation failed

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+2 -2)

📄 Description

build with rust 1.81.0, by running

cargo install -v --profile release --features "resolver,dns-over-https-rustls,dns-over-quic,dns-over-h3,native-certs,dnssec-ring,recursor" --no-default-features --path ./bin

error[E0308]: `match` arms have incompatible types
   --> bin/src/hickory-dns.rs:216:13
    |
170 |       let authority = match zone_config.stores {
    |  _____________________-
171 | |         #[cfg(feature = "sqlite")]
172 | |         Some(StoreConfig::Sqlite(ref config)) => {
173 | |             if zone_path.is_some() {
...   |
210 | |             Arc::new(authority)
    | |             ------------------- this is found to be of type `Arc<FileAuthority>`
...   |
216 | |             Arc::new(forwarder)
    | |             ^^^^^^^^^^^^^^^^^^^ expected `Arc<FileAuthority>`, found `Arc<ForwardAuthority>`
...   |
281 | |         }
282 | |     };
    | |_____- `match` arms have incompatible types
    |
    = note: expected struct `Arc<FileAuthority>`
               found struct `Arc<ForwardAuthority>`

For more information about this error, try `rustc --explain E0308`.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2476 **Author:** [@hingbong](https://github.com/hingbong) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e817935`](https://github.com/hickory-dns/hickory-dns/commit/e817935121b0da292f63097cd88e7bf9b86883b2) fix compilation failed ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+2 -2) </details> ### 📄 Description build with rust 1.81.0, by running ``` cargo install -v --profile release --features "resolver,dns-over-https-rustls,dns-over-quic,dns-over-h3,native-certs,dnssec-ring,recursor" --no-default-features --path ./bin ``` ``` error[E0308]: `match` arms have incompatible types --> bin/src/hickory-dns.rs:216:13 | 170 | let authority = match zone_config.stores { | _____________________- 171 | | #[cfg(feature = "sqlite")] 172 | | Some(StoreConfig::Sqlite(ref config)) => { 173 | | if zone_path.is_some() { ... | 210 | | Arc::new(authority) | | ------------------- this is found to be of type `Arc<FileAuthority>` ... | 216 | | Arc::new(forwarder) | | ^^^^^^^^^^^^^^^^^^^ expected `Arc<FileAuthority>`, found `Arc<ForwardAuthority>` ... | 281 | | } 282 | | }; | |_____- `match` arms have incompatible types | = note: expected struct `Arc<FileAuthority>` found struct `Arc<ForwardAuthority>` For more information about this error, try `rustc --explain E0308`. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>