[PR #2472] [MERGED] proto: use RuntimeProvider to connect TCP #3066

New issue

Closed

opened 2026-03-16 11:23:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2472
Author: @djc
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @djc

Base: main ← Head: provider-tcp

📝 Commits (5)

1a6dfb4 proto: extend RuntimeProvider::connect_tcp() with bind_addr argument
81872c1 proto: rebuild Connect impl on top of RuntimeProvider
db78fd6 async-std-resolver: use unqualified types
94257e1 proto: time out TCP connects by default
7de7ef7 proto: use RuntimeProvider to connect TCP

📊 Changes

41 files changed (+524 additions, -637 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+2 -4)
📝 bin/tests/integration/named_https_tests.rs (+4 -6)
📝 bin/tests/integration/named_rustls_tests.rs (+6 -8)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+11 -14)
📝 bin/tests/integration/named_tests.rs (+29 -21)
📝 crates/async-std-resolver/src/net.rs (+10 -47)
📝 crates/async-std-resolver/src/runtime.rs (+40 -3)
📝 crates/client/src/client/async_client.rs (+10 -7)
📝 crates/client/src/client/client.rs (+4 -2)
📝 crates/client/src/h2_client_connection.rs (+19 -19)
📝 crates/client/src/lib.rs (+2 -2)
📝 crates/client/src/tcp/tcp_client_connection.rs (+30 -20)
📝 crates/proto/src/h2/h2_client_stream.rs (+34 -30)
📝 crates/proto/src/native_tls/tests.rs (+2 -1)
📝 crates/proto/src/native_tls/tls_client_stream.rs (+9 -16)
📝 crates/proto/src/native_tls/tls_stream.rs (+14 -17)
📝 crates/proto/src/openssl/tls_client_stream.rs (+10 -18)
📝 crates/proto/src/openssl/tls_stream.rs (+12 -14)
📝 crates/proto/src/runtime.rs (+28 -3)
📝 crates/proto/src/rustls/tests.rs (+3 -3)

...and 21 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2472 **Author:** [@djc](https://github.com/djc) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `provider-tcp` --- ### 📝 Commits (5) - [`1a6dfb4`](https://github.com/hickory-dns/hickory-dns/commit/1a6dfb46005593b6ca736a33f2d46952ea62282b) proto: extend RuntimeProvider::connect_tcp() with bind_addr argument - [`81872c1`](https://github.com/hickory-dns/hickory-dns/commit/81872c18475aaf921ec7696762daac054cd7cc70) proto: rebuild Connect impl on top of RuntimeProvider - [`db78fd6`](https://github.com/hickory-dns/hickory-dns/commit/db78fd6a50934955170ab22875f4389f446d68d3) async-std-resolver: use unqualified types - [`94257e1`](https://github.com/hickory-dns/hickory-dns/commit/94257e1fa4186fc44686b1a6954a47fc0a8f33b9) proto: time out TCP connects by default - [`7de7ef7`](https://github.com/hickory-dns/hickory-dns/commit/7de7ef768ca43322a352b1d7171ae5605db55b6e) proto: use RuntimeProvider to connect TCP ### 📊 Changes **41 files changed** (+524 additions, -637 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+2 -4) 📝 `bin/tests/integration/named_https_tests.rs` (+4 -6) 📝 `bin/tests/integration/named_rustls_tests.rs` (+6 -8) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+11 -14) 📝 `bin/tests/integration/named_tests.rs` (+29 -21) 📝 `crates/async-std-resolver/src/net.rs` (+10 -47) 📝 `crates/async-std-resolver/src/runtime.rs` (+40 -3) 📝 `crates/client/src/client/async_client.rs` (+10 -7) 📝 `crates/client/src/client/client.rs` (+4 -2) 📝 `crates/client/src/h2_client_connection.rs` (+19 -19) 📝 `crates/client/src/lib.rs` (+2 -2) 📝 `crates/client/src/tcp/tcp_client_connection.rs` (+30 -20) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+34 -30) 📝 `crates/proto/src/native_tls/tests.rs` (+2 -1) 📝 `crates/proto/src/native_tls/tls_client_stream.rs` (+9 -16) 📝 `crates/proto/src/native_tls/tls_stream.rs` (+14 -17) 📝 `crates/proto/src/openssl/tls_client_stream.rs` (+10 -18) 📝 `crates/proto/src/openssl/tls_stream.rs` (+12 -14) 📝 `crates/proto/src/runtime.rs` (+28 -3) 📝 `crates/proto/src/rustls/tests.rs` (+3 -3) _...and 21 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>