[PR #2467] [MERGED] Kill quad9 tests #3060

Closed
opened 2026-03-16 11:23:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2467
Author: @djc
Created: 9/19/2024
Status: Merged
Merged: 9/19/2024
Merged by: @djc

Base: mainHead: kill-quad9-tests


📝 Commits (2)

📊 Changes

3 files changed (+0 additions, -27 deletions)

View changed files

📝 crates/async-std-resolver/src/tests.rs (+0 -11)
📝 crates/resolver/src/async_resolver.rs (+0 -8)
📝 crates/resolver/src/tls/mod.rs (+0 -8)

📄 Description

Recently the Quad9 tests have been breaking in CI a lot. Given that we already have tests for Google and Cloudflare, I feel like the incremental value these Quad9 tests provide is negligible, and so having these tests has become a net negative.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2467 **Author:** [@djc](https://github.com/djc) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `kill-quad9-tests` --- ### 📝 Commits (2) - [`0461dad`](https://github.com/hickory-dns/hickory-dns/commit/0461dad11191e70f81846af76eed19a890747ed5) Remove quad9 tests - [`c438439`](https://github.com/hickory-dns/hickory-dns/commit/c43843952316f7c1a8efcfc2428afc9687f430cb) Enable Windows tests ### 📊 Changes **3 files changed** (+0 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/src/tests.rs` (+0 -11) 📝 `crates/resolver/src/async_resolver.rs` (+0 -8) 📝 `crates/resolver/src/tls/mod.rs` (+0 -8) </details> ### 📄 Description Recently the Quad9 tests have been breaking in CI a lot. Given that we already have tests for Google and Cloudflare, I feel like the incremental value these Quad9 tests provide is negligible, and so having these tests has become a net negative. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:23:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3060
No description provided.