[PR #2454] [MERGED] Extract tracing-subscriber setup to new crate #3051

New issue

Closed

opened 2026-03-16 11:22:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2454
Author: @divergentdave
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @djc

Base: main ← Head: david/test-support-crate

📝 Commits (1)

f7831a6 Extract tracing-subscriber setup to new crate

📊 Changes

29 files changed (+84 additions, -126 deletions)

View changed files

📝 Cargo.lock (+14 -2)
📝 Cargo.toml (+2 -0)
📝 bin/Cargo.toml (+1 -0)
📝 bin/tests/integration/main.rs (+0 -15)
📝 bin/tests/integration/named_https_tests.rs (+1 -1)
📝 bin/tests/integration/named_quic_tests.rs (+2 -4)
📝 bin/tests/integration/named_tests.rs (+2 -2)
📝 crates/async-std-resolver/Cargo.toml (+1 -2)
📝 crates/async-std-resolver/src/tests.rs (+1 -15)
📝 crates/proto/Cargo.toml (+1 -0)
📝 crates/proto/src/h2/h2_client_stream.rs (+1 -1)
📝 crates/proto/src/h3/h3_client_stream.rs (+1 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+2 -1)
📝 crates/proto/src/tests/mod.rs (+0 -17)
📝 crates/proto/src/udp/udp_client_stream.rs (+2 -1)
📝 crates/resolver/Cargo.toml (+1 -0)
📝 crates/resolver/src/async_resolver.rs (+4 -18)
📝 crates/resolver/src/name_server/name_server.rs (+1 -1)
📝 crates/server/Cargo.toml (+1 -0)
📝 crates/server/tests/integration/authority_battery/basic.rs (+1 -1)

...and 9 more files

📄 Description

This is a follow-up to #2453 to extract the duplicated setup function into a new test support crate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2454 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/test-support-crate` --- ### 📝 Commits (1) - [`f7831a6`](https://github.com/hickory-dns/hickory-dns/commit/f7831a6413726314c6f7809d51ff1e6e187bbe9a) Extract tracing-subscriber setup to new crate ### 📊 Changes **29 files changed** (+84 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+14 -2) 📝 `Cargo.toml` (+2 -0) 📝 `bin/Cargo.toml` (+1 -0) 📝 `bin/tests/integration/main.rs` (+0 -15) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_quic_tests.rs` (+2 -4) 📝 `bin/tests/integration/named_tests.rs` (+2 -2) 📝 `crates/async-std-resolver/Cargo.toml` (+1 -2) 📝 `crates/async-std-resolver/src/tests.rs` (+1 -15) 📝 `crates/proto/Cargo.toml` (+1 -0) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+1 -1) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+1 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -1) 📝 `crates/proto/src/tests/mod.rs` (+0 -17) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+2 -1) 📝 `crates/resolver/Cargo.toml` (+1 -0) 📝 `crates/resolver/src/async_resolver.rs` (+4 -18) 📝 `crates/resolver/src/name_server/name_server.rs` (+1 -1) 📝 `crates/server/Cargo.toml` (+1 -0) 📝 `crates/server/tests/integration/authority_battery/basic.rs` (+1 -1) _...and 9 more files_ </details> ### 📄 Description This is a follow-up to #2453 to extract the duplicated setup function into a new test support crate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>