[PR #2450] [MERGED] Minor recursor tweaks #3050

New issue

Closed

opened 2026-03-16 11:22:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2450
Author: @djc
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @djc

Base: main ← Head: recursor-tweaks

📝 Commits (3)

2a68f6c recursor: move Default impl below inherent impl
5d62b0e Use nice formatting for numbers
cc23a73 recursor: deduplicate default values

📊 Changes

20 files changed (+57 additions, -62 deletions)

View changed files

📝 conformance/packages/dns-test/src/zone_file/signer.rs (+8 -8)
📝 crates/client/src/tests.rs (+2 -2)
📝 crates/proto/src/h2/h2_client_stream.rs (+1 -1)
📝 crates/proto/src/h2/h2_server.rs (+1 -1)
📝 crates/proto/src/h3/h3_client_stream.rs (+1 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+1 -1)
📝 crates/proto/src/op/message.rs (+2 -2)
📝 crates/proto/src/rr/dnssec/keypair.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/signer.rs (+3 -3)
📝 crates/proto/src/serialize/txt/zone_lex.rs (+1 -1)
📝 crates/proto/src/udp/mod.rs (+1 -1)
📝 crates/proto/src/udp/udp_stream.rs (+1 -1)
📝 crates/proto/tests/integration/openssl_tests.rs (+2 -2)
📝 crates/recursor/src/recursor.rs (+11 -11)
📝 crates/server/src/server/server_future.rs (+6 -6)
📝 crates/server/src/store/recursor/authority.rs (+10 -6)
📝 crates/server/src/store/recursor/config.rs (+2 -11)
📝 tests/integration-tests/src/example_authority.rs (+1 -1)
📝 tests/integration-tests/tests/integration/client_future_tests.rs (+1 -1)
📝 tests/integration-tests/tests/integration/client_tests.rs (+1 -1)

📄 Description

Some things I noticed reviewing #2339.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2450 **Author:** [@djc](https://github.com/djc) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `recursor-tweaks` --- ### 📝 Commits (3) - [`2a68f6c`](https://github.com/hickory-dns/hickory-dns/commit/2a68f6c7ecd3387aefcad3c78b493c772bf7dbc8) recursor: move Default impl below inherent impl - [`5d62b0e`](https://github.com/hickory-dns/hickory-dns/commit/5d62b0e2eb4d904671a1b440104d8c2b4bd7fa85) Use nice formatting for numbers - [`cc23a73`](https://github.com/hickory-dns/hickory-dns/commit/cc23a737a4e5e3ccc1d42727b31e9c0ce0004f03) recursor: deduplicate default values ### 📊 Changes **20 files changed** (+57 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/zone_file/signer.rs` (+8 -8) 📝 `crates/client/src/tests.rs` (+2 -2) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+1 -1) 📝 `crates/proto/src/h2/h2_server.rs` (+1 -1) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+1 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+1 -1) 📝 `crates/proto/src/op/message.rs` (+2 -2) 📝 `crates/proto/src/rr/dnssec/keypair.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/signer.rs` (+3 -3) 📝 `crates/proto/src/serialize/txt/zone_lex.rs` (+1 -1) 📝 `crates/proto/src/udp/mod.rs` (+1 -1) 📝 `crates/proto/src/udp/udp_stream.rs` (+1 -1) 📝 `crates/proto/tests/integration/openssl_tests.rs` (+2 -2) 📝 `crates/recursor/src/recursor.rs` (+11 -11) 📝 `crates/server/src/server/server_future.rs` (+6 -6) 📝 `crates/server/src/store/recursor/authority.rs` (+10 -6) 📝 `crates/server/src/store/recursor/config.rs` (+2 -11) 📝 `tests/integration-tests/src/example_authority.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/client_future_tests.rs` (+1 -1) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+1 -1) </details> ### 📄 Description Some things I noticed reviewing #2339. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>