[PR #2448] [MERGED] Unify integration tests #3048

New issue

Closed

opened 2026-03-16 11:22:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2448
Author: @divergentdave
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @djc

Base: main ← Head: david/unify-integration-tests

📝 Commits (5)

da8e83f Unify binary crate integration tests
e1c190c Unify proto crate integration tests
c5d574f Unify server crate integration tests
778f182 Unify compat crate integration tests
e518ccc Unify integration crate integration tests

📊 Changes

40 files changed (+63 additions, -47 deletions)

View changed files

➕ bin/tests/integration/main.rs (+7 -0)
📝 bin/tests/integration/named_https_tests.rs (+1 -3)
📝 bin/tests/integration/named_openssl_tests.rs (+1 -3)
📝 bin/tests/integration/named_quic_tests.rs (+1 -3)
📝 bin/tests/integration/named_rustls_tests.rs (+1 -3)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+1 -3)
📝 bin/tests/integration/named_tests.rs (+2 -3)
📝 bin/tests/integration/server_harness/mod.rs (+0 -0)
📝 bin/tests/integration/server_harness/mut_message_client.rs (+0 -0)
📝 crates/proto/tests/integration/dnssec_presentation_format_tests.rs (+5 -5)
➕ crates/proto/tests/integration/main.rs (+2 -0)
📝 crates/proto/tests/integration/openssl_tests.rs (+0 -0)
📝 crates/server/tests/integration/authority_battery/basic.rs (+4 -4)
📝 crates/server/tests/integration/authority_battery/dnssec.rs (+4 -4)
📝 crates/server/tests/integration/authority_battery/dynamic_update.rs (+4 -4)
📝 crates/server/tests/integration/authority_battery/mod.rs (+0 -0)
📝 crates/server/tests/integration/config_tests.rs (+0 -0)
📝 crates/server/tests/integration/forwarder.rs (+0 -1)
📝 crates/server/tests/integration/in_memory.rs (+0 -0)
➕ crates/server/tests/integration/main.rs (+12 -0)

...and 20 more files

📄 Description

This unifies integration tests into one target per crate, in five different crates. I had to fix up some macro calls that cared about module paths or file paths. This closes #2444.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2448 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/unify-integration-tests` --- ### 📝 Commits (5) - [`da8e83f`](https://github.com/hickory-dns/hickory-dns/commit/da8e83f4aa27eed47bbcd4c160d650e7aa39ab1c) Unify binary crate integration tests - [`e1c190c`](https://github.com/hickory-dns/hickory-dns/commit/e1c190cad30a170ab43950d2ba4dc89d60647e21) Unify proto crate integration tests - [`c5d574f`](https://github.com/hickory-dns/hickory-dns/commit/c5d574f627d3d66c4db88da0f1fd1cdf61700de6) Unify server crate integration tests - [`778f182`](https://github.com/hickory-dns/hickory-dns/commit/778f182e97f1993ad18c5af2df8c6db29c07c628) Unify compat crate integration tests - [`e518ccc`](https://github.com/hickory-dns/hickory-dns/commit/e518ccc87ffd6b51dfe86dbd2d89e03fb5aaf9c1) Unify integration crate integration tests ### 📊 Changes **40 files changed** (+63 additions, -47 deletions) <details> <summary>View changed files</summary> ➕ `bin/tests/integration/main.rs` (+7 -0) 📝 `bin/tests/integration/named_https_tests.rs` (+1 -3) 📝 `bin/tests/integration/named_openssl_tests.rs` (+1 -3) 📝 `bin/tests/integration/named_quic_tests.rs` (+1 -3) 📝 `bin/tests/integration/named_rustls_tests.rs` (+1 -3) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+1 -3) 📝 `bin/tests/integration/named_tests.rs` (+2 -3) 📝 `bin/tests/integration/server_harness/mod.rs` (+0 -0) 📝 `bin/tests/integration/server_harness/mut_message_client.rs` (+0 -0) 📝 `crates/proto/tests/integration/dnssec_presentation_format_tests.rs` (+5 -5) ➕ `crates/proto/tests/integration/main.rs` (+2 -0) 📝 `crates/proto/tests/integration/openssl_tests.rs` (+0 -0) 📝 `crates/server/tests/integration/authority_battery/basic.rs` (+4 -4) 📝 `crates/server/tests/integration/authority_battery/dnssec.rs` (+4 -4) 📝 `crates/server/tests/integration/authority_battery/dynamic_update.rs` (+4 -4) 📝 `crates/server/tests/integration/authority_battery/mod.rs` (+0 -0) 📝 `crates/server/tests/integration/config_tests.rs` (+0 -0) 📝 `crates/server/tests/integration/forwarder.rs` (+0 -1) 📝 `crates/server/tests/integration/in_memory.rs` (+0 -0) ➕ `crates/server/tests/integration/main.rs` (+12 -0) _...and 20 more files_ </details> ### 📄 Description This unifies integration tests into one target per crate, in five different crates. I had to fix up some macro calls that cared about module paths or file paths. This closes #2444. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>