[PR #2443] [MERGED] treat zone as Insecure if all DNSKEY algorithms are unsupported #3046

New issue

Closed

opened 2026-03-16 11:22:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:22:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2443
Author: @japaric
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @marcus0x62

Base: main ← Head: ja-deprecated-algo-is-insecure

📝 Commits (2)

296e742 add Algorithm::is_supported
92fea2c treat zone as Insecure if all DNSKEY algorithms are unsupported

📊 Changes

6 files changed (+43 additions, -5 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs (+0 -2)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+16 -0)
📝 crates/proto/src/rr/dnssec/proof.rs (+5 -1)
📝 crates/proto/src/rr/dnssec/public_key.rs (+3 -0)
📝 crates/proto/src/xfer/dnssec_dns_handle/mod.rs (+19 -0)
📝 tests/ede-dot-com/src/lib.rs (+0 -2)

📄 Description

this fixes the diagnostics of two more ede-dot-com tests

~~depends on #2438 so opening as a draft until that is merged~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2443 **Author:** [@japaric](https://github.com/japaric) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@marcus0x62](https://github.com/marcus0x62) **Base:** `main` ← **Head:** `ja-deprecated-algo-is-insecure` --- ### 📝 Commits (2) - [`296e742`](https://github.com/hickory-dns/hickory-dns/commit/296e7426bef04c5d88d6805136210810d310c98c) add Algorithm::is_supported - [`92fea2c`](https://github.com/hickory-dns/hickory-dns/commit/92fea2c140b15c6caff6de255be63e789d1dca0a) treat zone as Insecure if all DNSKEY algorithms are unsupported ### 📊 Changes **6 files changed** (+43 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs` (+0 -2) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+16 -0) 📝 `crates/proto/src/rr/dnssec/proof.rs` (+5 -1) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+3 -0) 📝 `crates/proto/src/xfer/dnssec_dns_handle/mod.rs` (+19 -0) 📝 `tests/ede-dot-com/src/lib.rs` (+0 -2) </details> ### 📄 Description this fixes the diagnostics of two more ede-dot-com tests ~~depends on #2438 so opening as a draft until that is merged~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>