[PR #2433] [CLOSED] Escape dots inside IDNA labels #3039

New issue

Closed

opened 2026-03-16 11:21:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2433
Author: @divergentdave
Created: 9/5/2024
Status: ❌ Closed

Base: main ← Head: david/escape-dot-unicode

📝 Commits (1)

7652ec0 Escape dots inside IDNA labels

📊 Changes

2 files changed (+14 additions, -1 deletions)

View changed files

📝 crates/proto/src/rr/domain/label.rs (+5 -1)
📝 crates/proto/src/rr/domain/name.rs (+9 -0)

📄 Description

This implements an idea I mentioned in #2419, escaping dots within labels when encoding them as UTF-8. I'm unfamiliar with applications where escaped dots are allowed in names, so I'm looking for feedback on whether this is the right approach.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2433 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/5/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `david/escape-dot-unicode` --- ### 📝 Commits (1) - [`7652ec0`](https://github.com/hickory-dns/hickory-dns/commit/7652ec06f1205fd98e226183c04a7f714b6be024) Escape dots inside IDNA labels ### 📊 Changes **2 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/domain/label.rs` (+5 -1) 📝 `crates/proto/src/rr/domain/name.rs` (+9 -0) </details> ### 📄 Description This implements an idea I mentioned in #2419, escaping dots within labels when encoding them as UTF-8. I'm unfamiliar with applications where escaped dots are allowed in names, so I'm looking for feedback on whether this is the right approach. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>