[PR #2427] [MERGED] fix key tag calculation in dns-test and semantic merge conflict in conformance test #3037

New issue

Closed

opened 2026-03-16 11:21:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2427
Author: @japaric
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @japaric

Base: main ← Head: ja-fix-ci-without-revert

📝 Commits (5)

f482dd7 implement key tag calculation for RSAMD5
d7245ac fix calculate_key_tag for odd-sized keys
e678c91 fix semantic merge conflict
9c1404f Clippy: remove unnecessary borrows
82921e2 fix clippy warnings

📊 Changes

5 files changed (+67 additions, -19 deletions)

View changed files

📝 bin/tests/server_harness/mod.rs (+6 -6)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs (+3 -3)
📝 conformance/packages/dns-test/src/container.rs (+2 -2)
📝 conformance/packages/dns-test/src/record.rs (+55 -7)
📝 tests/compatibility-tests/src/bind.rs (+1 -1)

📄 Description

this fixes CI

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2427 **Author:** [@japaric](https://github.com/japaric) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-fix-ci-without-revert` --- ### 📝 Commits (5) - [`f482dd7`](https://github.com/hickory-dns/hickory-dns/commit/f482dd7133d69fd835c5bbf602942558c4ac6bc0) implement key tag calculation for RSAMD5 - [`d7245ac`](https://github.com/hickory-dns/hickory-dns/commit/d7245ac6782b6c53b98ab56bf2ed192c61a83b10) fix calculate_key_tag for odd-sized keys - [`e678c91`](https://github.com/hickory-dns/hickory-dns/commit/e678c9115b41a0d7d906821a24e544379b901e27) fix semantic merge conflict - [`9c1404f`](https://github.com/hickory-dns/hickory-dns/commit/9c1404f9eff6db726350b8e2370b4e6196347c2d) Clippy: remove unnecessary borrows - [`82921e2`](https://github.com/hickory-dns/hickory-dns/commit/82921e27ccfbb2558068941daa9e3799a22fe486) fix clippy warnings ### 📊 Changes **5 files changed** (+67 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/server_harness/mod.rs` (+6 -6) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs` (+3 -3) 📝 `conformance/packages/dns-test/src/container.rs` (+2 -2) 📝 `conformance/packages/dns-test/src/record.rs` (+55 -7) 📝 `tests/compatibility-tests/src/bind.rs` (+1 -1) </details> ### 📄 Description this fixes CI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>