[PR #2423] [CLOSED] revert 'conformance: deprecated algorithms' to fix CI again #3033

New issue

Closed

opened 2026-03-16 11:21:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2423
Author: @japaric
Created: 9/5/2024
Status: ❌ Closed

Base: main ← Head: ja-fix-ci-again

📝 Commits (1)

9fb3914 Revert "conformance: test against deprecated algorithms"

📊 Changes

2 files changed (+0 additions, -132 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure.rs (+0 -2)
➖ conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs (+0 -130)

📄 Description

commit was part of PR #2413 . the implementation needs to be adjusted after #2409 landed since the calculation of the key tag is different with these old algorithms

FYI @djc another PR sneaked through the merge queue and broke CI ... you may want to enable the 'require PR to be up to date prior to merging' setting even though I thought the merge queue would always rebase before running CI checks ...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2423 **Author:** [@japaric](https://github.com/japaric) **Created:** 9/5/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ja-fix-ci-again` --- ### 📝 Commits (1) - [`9fb3914`](https://github.com/hickory-dns/hickory-dns/commit/9fb3914a7fe003dcf1598aefc18a188deec5f775) Revert "conformance: test against deprecated algorithms" ### 📊 Changes **2 files changed** (+0 additions, -132 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure.rs` (+0 -2) ➖ `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/insecure/deprecated_algorithm.rs` (+0 -130) </details> ### 📄 Description commit was part of PR #2413 . the implementation needs to be adjusted after #2409 landed since the calculation of the key tag is different with these old algorithms FYI @djc another PR sneaked through the merge queue and broke CI ... you may want to enable the 'require PR to be up to date prior to merging' setting even though I thought the merge queue would always rebase before running CI checks ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>