[PR #2418] [MERGED] Store invalid CAA property value as Value::Unknown #3027

New issue

Closed

opened 2026-03-16 11:21:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2418
Author: @divergentdave
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @djc

Base: main ← Head: david/caa-value-fallback

📝 Commits (1)

9835f4d Store invalid CAA property value as Value::Unknown

📊 Changes

1 file changed (+41 additions, -12 deletions)

View changed files

📝 crates/proto/src/rr/rdata/caa.rs (+41 -12)

📄 Description

This stores CAA property values as Value::Unknown if the value cannot be parsed. This lets a large class of records be round-tripped, when they would have been dropped before, which is important for letting downstream systems comply with the CAA RFC. Closes #2415. I updated one affected unit test, and added some more to cover invalid name cases.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2418 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/caa-value-fallback` --- ### 📝 Commits (1) - [`9835f4d`](https://github.com/hickory-dns/hickory-dns/commit/9835f4d58941bfd8e24e5eaaab7dca3e9933621f) Store invalid CAA property value as Value::Unknown ### 📊 Changes **1 file changed** (+41 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/caa.rs` (+41 -12) </details> ### 📄 Description This stores CAA property values as `Value::Unknown` if the value cannot be parsed. This lets a large class of records be round-tripped, when they would have been dropped before, which is important for letting downstream systems comply with the CAA RFC. Closes #2415. I updated one affected unit test, and added some more to cover invalid name cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>