[PR #2391] [MERGED] Add NSEC3 support to `hickory-server` #3005

New issue

Closed

opened 2026-03-16 11:20:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:20:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2391
Author: @pvdrz
Created: 8/28/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @pvdrz

Base: main ← Head: nsec3-impl

📝 Commits (5)

f3d5312 Make the kind of non-existence proof used configurable
54e5e49 Let hickory sign the zonefile itself
09af851 Implement NSEC3 zone signing
8b2e86c Implement NSEC3 zone serving
00bfaf0 Log the request ID on failure

📊 Changes

32 files changed (+863 additions, -77 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 bin/src/hickory-dns.rs (+8 -0)
📝 conformance/packages/conformance-tests/src/name_server/rfc5155.rs (+7 -6)
📝 conformance/packages/dns-test/src/container.rs (+1 -0)
📝 conformance/packages/dns-test/src/docker/hickory.Dockerfile (+4 -2)
📝 conformance/packages/dns-test/src/implementation.rs (+4 -2)
📝 conformance/packages/dns-test/src/name_server.rs (+21 -1)
📝 conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja (+7 -0)
📝 conformance/packages/dns-test/src/zone_file/signer.rs (+10 -2)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+2 -1)
📝 crates/proto/src/rr/domain/name.rs (+22 -0)
📝 crates/server/Cargo.toml (+5 -1)
📝 crates/server/src/authority/authority.rs (+65 -4)
📝 crates/server/src/authority/authority_object.rs (+29 -0)
📝 crates/server/src/authority/catalog.rs (+95 -18)
📝 crates/server/src/authority/mod.rs (+1 -1)
📝 crates/server/src/config/dnssec.rs (+24 -1)
📝 crates/server/src/config/mod.rs (+8 -0)
📝 crates/server/src/store/file/authority.rs (+41 -7)
📝 crates/server/src/store/forwarder/authority.rs (+19 -0)

...and 12 more files

📄 Description

A (hopefully) cleaner version of #2344

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2391 **Author:** [@pvdrz](https://github.com/pvdrz) **Created:** 8/28/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@pvdrz](https://github.com/pvdrz) **Base:** `main` ← **Head:** `nsec3-impl` --- ### 📝 Commits (5) - [`f3d5312`](https://github.com/hickory-dns/hickory-dns/commit/f3d5312bbc238f74d9dc46bfb52aedfe917bc6d5) Make the kind of non-existence proof used configurable - [`54e5e49`](https://github.com/hickory-dns/hickory-dns/commit/54e5e497fef45376cb4bbf52574f8197e9f25a15) Let hickory sign the zonefile itself - [`09af851`](https://github.com/hickory-dns/hickory-dns/commit/09af8514c1586879edf43ce6ab20c7d72126b72f) Implement NSEC3 zone signing - [`8b2e86c`](https://github.com/hickory-dns/hickory-dns/commit/8b2e86c322d29d46e5e4b2274660557fddf2cc01) Implement NSEC3 zone serving - [`00bfaf0`](https://github.com/hickory-dns/hickory-dns/commit/00bfaf049bd38955898a514d26b8db928f214087) Log the request ID on failure ### 📊 Changes **32 files changed** (+863 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `bin/src/hickory-dns.rs` (+8 -0) 📝 `conformance/packages/conformance-tests/src/name_server/rfc5155.rs` (+7 -6) 📝 `conformance/packages/dns-test/src/container.rs` (+1 -0) 📝 `conformance/packages/dns-test/src/docker/hickory.Dockerfile` (+4 -2) 📝 `conformance/packages/dns-test/src/implementation.rs` (+4 -2) 📝 `conformance/packages/dns-test/src/name_server.rs` (+21 -1) 📝 `conformance/packages/dns-test/src/templates/hickory.name-server.toml.jinja` (+7 -0) 📝 `conformance/packages/dns-test/src/zone_file/signer.rs` (+10 -2) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+2 -1) 📝 `crates/proto/src/rr/domain/name.rs` (+22 -0) 📝 `crates/server/Cargo.toml` (+5 -1) 📝 `crates/server/src/authority/authority.rs` (+65 -4) 📝 `crates/server/src/authority/authority_object.rs` (+29 -0) 📝 `crates/server/src/authority/catalog.rs` (+95 -18) 📝 `crates/server/src/authority/mod.rs` (+1 -1) 📝 `crates/server/src/config/dnssec.rs` (+24 -1) 📝 `crates/server/src/config/mod.rs` (+8 -0) 📝 `crates/server/src/store/file/authority.rs` (+41 -7) 📝 `crates/server/src/store/forwarder/authority.rs` (+19 -0) _...and 12 more files_ </details> ### 📄 Description A (hopefully) cleaner version of #2344 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>