[PR #2372] [MERGED] Use container names, not IDs, in "explore" example #2990

New issue

Closed

opened 2026-03-16 11:19:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:19:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2372
Author: @divergentdave
Created: 8/21/2024
Status: ✅ Merged
Merged: 8/26/2024
Merged by: @japaric

Base: main ← Head: david/conformance-example-container-names

📝 Commits (1)

8c920d2 Use container names, not IDs, in "explore" example

📊 Changes

5 files changed (+19 additions, -3 deletions)

View changed files

📝 conformance/packages/dns-test/examples/explore.rs (+3 -3)
📝 conformance/packages/dns-test/src/client.rs (+4 -0)
📝 conformance/packages/dns-test/src/container.rs (+4 -0)
📝 conformance/packages/dns-test/src/name_server.rs (+4 -0)
📝 conformance/packages/dns-test/src/resolver.rs (+4 -0)

📄 Description

This changes the explore example to use container names instead of container IDs in the docker commands it prints out. I prefer using names here because they are shorter, more understandable, and easier to tab-complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2372 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `david/conformance-example-container-names` --- ### 📝 Commits (1) - [`8c920d2`](https://github.com/hickory-dns/hickory-dns/commit/8c920d2f87733d89223fea4ada2944a39e2d5346) Use container names, not IDs, in "explore" example ### 📊 Changes **5 files changed** (+19 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/examples/explore.rs` (+3 -3) 📝 `conformance/packages/dns-test/src/client.rs` (+4 -0) 📝 `conformance/packages/dns-test/src/container.rs` (+4 -0) 📝 `conformance/packages/dns-test/src/name_server.rs` (+4 -0) 📝 `conformance/packages/dns-test/src/resolver.rs` (+4 -0) </details> ### 📄 Description This changes the `explore` example to use container names instead of container IDs in the `docker` commands it prints out. I prefer using names here because they are shorter, more understandable, and easier to tab-complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>