[PR #2368] [MERGED] Fix panic in NSEC3 hash function #2987

Closed
opened 2026-03-16 11:19:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2368
Author: @marcus0x62
Created: 8/21/2024
Status: Merged
Merged: 8/22/2024
Merged by: @pvdrz

Base: mainHead: nsec3_hash_panic_fix


📝 Commits (1)

  • e074242 Fix panic in hash function and add test for regression

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 crates/proto/src/rr/dnssec/nsec3.rs (+7 -1)

📄 Description

It is possible to trigger a panic in the NSEC3 hash function by passing a long (> 255 character) input name. This PR propagates the error back to the caller to handle properly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2368 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 8/21/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@pvdrz](https://github.com/pvdrz) **Base:** `main` ← **Head:** `nsec3_hash_panic_fix` --- ### 📝 Commits (1) - [`e074242`](https://github.com/hickory-dns/hickory-dns/commit/e0742423f3345fe1c0e4c408d6d2cb19fdde20d5) Fix panic in hash function and add test for regression ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+7 -1) </details> ### 📄 Description It is possible to trigger a panic in the NSEC3 hash function by passing a long (> 255 character) input name. This PR propagates the error back to the caller to handle properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:19:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2987
No description provided.