[PR #2366] [MERGED] Explicitly limit H2 support to rustls #2985

New issue

Closed

opened 2026-03-16 11:19:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:19:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2366
Author: @djc
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @djc

Base: main ← Head: https-rustls

📝 Commits (1)

952523b Explicitly limit H2 support to rustls

📊 Changes

21 files changed (+51 additions, -74 deletions)

View changed files

📝 bin/Cargo.toml (+0 -4)
📝 bin/src/hickory-dns.rs (+5 -5)
📝 bin/tests/named_https_tests.rs (+1 -1)
📝 bin/tests/server_harness/mod.rs (+1 -1)
📝 crates/client/Cargo.toml (+0 -4)
📝 crates/client/src/lib.rs (+3 -3)
📝 crates/proto/Cargo.toml (+1 -2)
📝 crates/proto/src/http/error.rs (+2 -2)
📝 crates/proto/src/http/mod.rs (+2 -2)
📝 crates/proto/src/http/request.rs (+2 -2)
📝 crates/proto/src/lib.rs (+4 -4)
📝 crates/recursor/Cargo.toml (+0 -2)
📝 crates/resolver/Cargo.toml (+0 -2)
📝 crates/resolver/src/config.rs (+20 -20)
📝 crates/resolver/src/lib.rs (+1 -1)
📝 crates/resolver/src/name_server/connection_provider.rs (+4 -4)
📝 crates/server/Cargo.toml (+2 -4)
📝 crates/server/src/server/mod.rs (+1 -1)
📝 tests/integration-tests/Cargo.toml (+0 -2)
📝 util/Cargo.toml (+0 -6)

...and 1 more files

📄 Description

Although the Cargo features have suggested that H2 support was available ever since the seeming introduction of DoH (in #541, I think?), it looks like the H2 implementation consistently depends on rustls. Make this explicit by removing the dns-over-https features from all crates in favor of only supporting dns-over-https-rustls.

Fixes #2365.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2366 **Author:** [@djc](https://github.com/djc) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `https-rustls` --- ### 📝 Commits (1) - [`952523b`](https://github.com/hickory-dns/hickory-dns/commit/952523be43489e556d55ce9d9b5d169ec92b4c04) Explicitly limit H2 support to rustls ### 📊 Changes **21 files changed** (+51 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `bin/Cargo.toml` (+0 -4) 📝 `bin/src/hickory-dns.rs` (+5 -5) 📝 `bin/tests/named_https_tests.rs` (+1 -1) 📝 `bin/tests/server_harness/mod.rs` (+1 -1) 📝 `crates/client/Cargo.toml` (+0 -4) 📝 `crates/client/src/lib.rs` (+3 -3) 📝 `crates/proto/Cargo.toml` (+1 -2) 📝 `crates/proto/src/http/error.rs` (+2 -2) 📝 `crates/proto/src/http/mod.rs` (+2 -2) 📝 `crates/proto/src/http/request.rs` (+2 -2) 📝 `crates/proto/src/lib.rs` (+4 -4) 📝 `crates/recursor/Cargo.toml` (+0 -2) 📝 `crates/resolver/Cargo.toml` (+0 -2) 📝 `crates/resolver/src/config.rs` (+20 -20) 📝 `crates/resolver/src/lib.rs` (+1 -1) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+4 -4) 📝 `crates/server/Cargo.toml` (+2 -4) 📝 `crates/server/src/server/mod.rs` (+1 -1) 📝 `tests/integration-tests/Cargo.toml` (+0 -2) 📝 `util/Cargo.toml` (+0 -6) _...and 1 more files_ </details> ### 📄 Description Although the Cargo features have suggested that H2 support was available ever since the seeming introduction of DoH (in #541, I think?), it looks like the H2 implementation consistently depends on rustls. Make this explicit by removing the `dns-over-https` features from all crates in favor of only supporting `dns-over-https-rustls`. Fixes #2365. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>