[PR #2356] [MERGED] Remove mentions of Makefile.toml in CONTRIBUTING.md #2984

New issue

Closed

opened 2026-03-16 11:18:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:18:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2356
Author: @divergentdave
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @djc

Base: main ← Head: david/update-contributing

📝 Commits (1)

2a4d83a Remove mentions of Makefile.toml in CONTRIBUTING.md

📊 Changes

1 file changed (+1 additions, -5 deletions)

View changed files

📝 CONTRIBUTING.md (+1 -5)

📄 Description

This removes a couple stale references to Makefile.toml from the contributing documentation. I see that the justfile does not install a Windows OpenSSL build like Makefile.toml used to, so I removed that section. I presume Windows tests are now using the OpenSSL version that comes pre-installed on GitHub Actions runners.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2356 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/update-contributing` --- ### 📝 Commits (1) - [`2a4d83a`](https://github.com/hickory-dns/hickory-dns/commit/2a4d83ac083c59b5fdd9b2b3b4734a5dda561518) Remove mentions of Makefile.toml in CONTRIBUTING.md ### 📊 Changes **1 file changed** (+1 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTING.md` (+1 -5) </details> ### 📄 Description This removes a couple stale references to `Makefile.toml` from the contributing documentation. I see that the justfile does not install a Windows OpenSSL build like `Makefile.toml` used to, so I removed that section. I presume Windows tests are now using the OpenSSL version that comes pre-installed on GitHub Actions runners. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>