[PR #2335] [MERGED] Simplify TBS construction API #2962

New issue

Closed

opened 2026-03-16 11:17:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2335
Author: @djc
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @djc

Base: main ← Head: dnssec-tbs

📝 Commits (4)

d079071 proto: refactor TBS constructors into associated functions
90c848d proto: simplify TBS construction argument
64e3568 proto: create higher-level constructor for TBS
3b5f124 proto: remove now unnecessary SerialNumber constructor

📊 Changes

9 files changed (+225 additions, -206 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 crates/proto/Cargo.toml (+1 -0)
📝 crates/proto/src/rr/dnssec/signer.rs (+3 -4)
📝 crates/proto/src/rr/dnssec/tbs.rs (+210 -171)
📝 crates/proto/src/rr/dnssec/verifier.rs (+5 -3)
📝 crates/proto/src/rr/serial_number.rs (+0 -5)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+1 -1)
📝 crates/server/src/store/in_memory/authority.rs (+3 -21)
📝 crates/server/tests/authority_battery/dnssec.rs (+1 -1)

📄 Description

This then avoids constructing SerialNumber across crate boundaries, so we can remove its public constructor.

cc @justahero

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2335 **Author:** [@djc](https://github.com/djc) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-tbs` --- ### 📝 Commits (4) - [`d079071`](https://github.com/hickory-dns/hickory-dns/commit/d07907171440917acc17afa3bb5e8b279366ccf1) proto: refactor TBS constructors into associated functions - [`90c848d`](https://github.com/hickory-dns/hickory-dns/commit/90c848d40a61910e5e1dd2f562136c4167e59175) proto: simplify TBS construction argument - [`64e3568`](https://github.com/hickory-dns/hickory-dns/commit/64e35689ad556d387d09d811b5586d0ac098099f) proto: create higher-level constructor for TBS - [`3b5f124`](https://github.com/hickory-dns/hickory-dns/commit/3b5f124067f7fd45e13403864d9e5dc6173ac51e) proto: remove now unnecessary SerialNumber constructor ### 📊 Changes **9 files changed** (+225 additions, -206 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `crates/proto/Cargo.toml` (+1 -0) 📝 `crates/proto/src/rr/dnssec/signer.rs` (+3 -4) 📝 `crates/proto/src/rr/dnssec/tbs.rs` (+210 -171) 📝 `crates/proto/src/rr/dnssec/verifier.rs` (+5 -3) 📝 `crates/proto/src/rr/serial_number.rs` (+0 -5) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+1 -1) 📝 `crates/server/src/store/in_memory/authority.rs` (+3 -21) 📝 `crates/server/tests/authority_battery/dnssec.rs` (+1 -1) </details> ### 📄 Description This then avoids constructing `SerialNumber` across crate boundaries, so we can remove its public constructor. cc @justahero --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>