[PR #2324] [MERGED] Fix warnings from Clippy 1.80 #2954

New issue

Closed

opened 2026-03-16 11:17:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2324
Author: @djc
Created: 7/25/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @djc

Base: main ← Head: clippy-1.80

📝 Commits (9)

ca5f7b5 resolver: remove disabled mDNS support
eadbf40 Remove disabled code for HMAC truncation
8c50dfb Bring back optional backtrace support
1b265fc server: remove unimplemented support for HTTPS with OpenSSL
29f4477 async-std-resolver: remove disabled tests for DNSSEC support
47c280d conformance: fix line contination in docs
96685fb Allow nightly cfg guard (used for benchmarks)
a82a9a0 justfile: fix benchmark builds
c0d4842 Move lower_name_benches to proto crate

📊 Changes

29 files changed (+52 additions, -701 deletions)

View changed files

📝 Cargo.lock (+2 -0)
📝 Cargo.toml (+3 -0)
📝 bin/Cargo.toml (+3 -0)
📝 bin/benches/comparison_benches.rs (+4 -3)
📝 conformance/packages/dns-test/src/name_server.rs (+1 -1)
📝 crates/async-std-resolver/Cargo.toml (+3 -0)
📝 crates/async-std-resolver/src/tests.rs (+0 -22)
📝 crates/client/Cargo.toml (+3 -0)
📝 crates/proto/Cargo.toml (+3 -0)
📝 crates/proto/benches/lib.rs (+14 -10)
📝 crates/proto/benches/lower_name_benches.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/tsig.rs (+0 -55)
📝 crates/recursor/Cargo.toml (+5 -2)
📝 crates/resolver/Cargo.toml (+5 -6)
📝 crates/resolver/README.md (+0 -1)
📝 crates/resolver/src/caching_client.rs (+0 -4)
📝 crates/resolver/src/config.rs (+0 -10)
➖ crates/resolver/src/dns_sd.rs (+0 -206)
📝 crates/resolver/src/lib.rs (+0 -1)
📝 crates/resolver/src/name_server/connection_provider.rs (+0 -34)

...and 9 more files

📄 Description

Since this release, Cargo and rustc warn against invalid cfg() expressions, of which there were quite a few.

resolver: remove disabled mDNS support
Has been disabled since #1433 (3 years ago).
Remove disabled code for HMAC truncation
Has been disabled since #1503 (3 years ago).
Bring back optional backtrace support
Disabled in #1710 without any discussion as far I saw (2 years ago). Given the lack of demand, we could just remove it?
server: remove unimplemented support for HTTPS with OpenSSL
async-std-resolver: remove disabled tests for DNSSEC support
Port benchmarks to bencher crate
This allows them to work on stable, making it more likely we find regressions (there were a couple, suggesting that the conditional CI job compiling them on nightly wasn't working correctly).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2324 **Author:** [@djc](https://github.com/djc) **Created:** 7/25/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `clippy-1.80` --- ### 📝 Commits (9) - [`ca5f7b5`](https://github.com/hickory-dns/hickory-dns/commit/ca5f7b51ab0a31e0bb39a9acb6d5629d0e2a3ee6) resolver: remove disabled mDNS support - [`eadbf40`](https://github.com/hickory-dns/hickory-dns/commit/eadbf4009a1ff5b18a31cc98126dfd825a47506d) Remove disabled code for HMAC truncation - [`8c50dfb`](https://github.com/hickory-dns/hickory-dns/commit/8c50dfb83b0fd314584f7edc9e855279e8afe6dd) Bring back optional backtrace support - [`1b265fc`](https://github.com/hickory-dns/hickory-dns/commit/1b265fce16fb81020b20954a1e68a6fd7076245b) server: remove unimplemented support for HTTPS with OpenSSL - [`29f4477`](https://github.com/hickory-dns/hickory-dns/commit/29f447775d0aad416815df7126094563c19d67d6) async-std-resolver: remove disabled tests for DNSSEC support - [`47c280d`](https://github.com/hickory-dns/hickory-dns/commit/47c280d642864b97ab5c96c73655e91ea4ec0224) conformance: fix line contination in docs - [`96685fb`](https://github.com/hickory-dns/hickory-dns/commit/96685fb98f0b1e145bd45b1818e42684ad5d07a8) Allow nightly cfg guard (used for benchmarks) - [`a82a9a0`](https://github.com/hickory-dns/hickory-dns/commit/a82a9a014a4341b851f5e13772bd8e4d1468c433) justfile: fix benchmark builds - [`c0d4842`](https://github.com/hickory-dns/hickory-dns/commit/c0d484223758d595498725819d6c3c0007a08737) Move lower_name_benches to proto crate ### 📊 Changes **29 files changed** (+52 additions, -701 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -0) 📝 `Cargo.toml` (+3 -0) 📝 `bin/Cargo.toml` (+3 -0) 📝 `bin/benches/comparison_benches.rs` (+4 -3) 📝 `conformance/packages/dns-test/src/name_server.rs` (+1 -1) 📝 `crates/async-std-resolver/Cargo.toml` (+3 -0) 📝 `crates/async-std-resolver/src/tests.rs` (+0 -22) 📝 `crates/client/Cargo.toml` (+3 -0) 📝 `crates/proto/Cargo.toml` (+3 -0) 📝 `crates/proto/benches/lib.rs` (+14 -10) 📝 `crates/proto/benches/lower_name_benches.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/tsig.rs` (+0 -55) 📝 `crates/recursor/Cargo.toml` (+5 -2) 📝 `crates/resolver/Cargo.toml` (+5 -6) 📝 `crates/resolver/README.md` (+0 -1) 📝 `crates/resolver/src/caching_client.rs` (+0 -4) 📝 `crates/resolver/src/config.rs` (+0 -10) ➖ `crates/resolver/src/dns_sd.rs` (+0 -206) 📝 `crates/resolver/src/lib.rs` (+0 -1) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+0 -34) _...and 9 more files_ </details> ### 📄 Description Since this release, Cargo and rustc warn against invalid `cfg()` expressions, of which there were quite a few. - resolver: remove disabled mDNS support Has been disabled since #1433 (3 years ago). - Remove disabled code for HMAC truncation Has been disabled since #1503 (3 years ago). - Bring back optional backtrace support Disabled in #1710 without any discussion as far I saw (2 years ago). Given the lack of demand, we could just remove it? - server: remove unimplemented support for HTTPS with OpenSSL - async-std-resolver: remove disabled tests for DNSSEC support - Port benchmarks to bencher crate This allows them to work on stable, making it more likely we find regressions (there were a couple, suggesting that the conditional CI job compiling them on nightly wasn't working correctly). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>