[PR #2311] [MERGED] Adjust TTL of RRSIG + RR during validation #2941

New issue

Closed

opened 2026-03-16 11:16:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2311
Author: @justahero
Created: 7/15/2024
Status: ✅ Merged
Merged: 7/21/2024
Merged by: @djc

Base: main ← Head: gh-2292-test-resolver-ttl-validation

📝 Commits (7)

20baea8 Add test to check TTL of valdiated record
122c315 Extract calculation of current time into function
82554bc Set TTL of RRSIG and RR
bb6687e Add test to check TTLs for RR + RRSIG
901d2d3 Move authenticated_ttl into RRSIG
e94c5d2 Refactor determination of TTL
20a1e7b Fix conformance test with unbound as subject

📊 Changes

5 files changed (+153 additions, -29 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_5/section_5_3.rs (+68 -1)
📝 conformance/packages/dns-test/src/record.rs (+8 -0)
📝 conformance/packages/dns-test/src/templates/unbound.conf.jinja (+1 -0)
📝 crates/proto/src/rr/dnssec/rdata/rrsig.rs (+29 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+47 -27)

📄 Description

This PR adjusts the TTL of RRSIG and its covering RR to conform to the last condition of RFC 4035, section 5.3.3.

add tests to check conditions

Closes #2292

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2311 **Author:** [@justahero](https://github.com/justahero) **Created:** 7/15/2024 **Status:** ✅ Merged **Merged:** 7/21/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `gh-2292-test-resolver-ttl-validation` --- ### 📝 Commits (7) - [`20baea8`](https://github.com/hickory-dns/hickory-dns/commit/20baea824f5d554483ee4a7f11fc73be0924e828) Add test to check TTL of valdiated record - [`122c315`](https://github.com/hickory-dns/hickory-dns/commit/122c31546bbce558fd85fc0ad9d5e3135f4cc21a) Extract calculation of current time into function - [`82554bc`](https://github.com/hickory-dns/hickory-dns/commit/82554bcd09a5151fd30d40a5dd2b05c403b3ddf4) Set TTL of RRSIG and RR - [`bb6687e`](https://github.com/hickory-dns/hickory-dns/commit/bb6687ef3eafcfe54b4d491af3a241ea3cf665a4) Add test to check TTLs for RR + RRSIG - [`901d2d3`](https://github.com/hickory-dns/hickory-dns/commit/901d2d3f4523d4c634152de0d0fa1cc945aa527d) Move authenticated_ttl into RRSIG - [`e94c5d2`](https://github.com/hickory-dns/hickory-dns/commit/e94c5d25ab8c4bb21894b71bd02b666a325c1f15) Refactor determination of TTL - [`20a1e7b`](https://github.com/hickory-dns/hickory-dns/commit/20a1e7b786b206a256dfd484954c8ca184e21a9c) Fix conformance test with unbound as subject ### 📊 Changes **5 files changed** (+153 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_5/section_5_3.rs` (+68 -1) 📝 `conformance/packages/dns-test/src/record.rs` (+8 -0) 📝 `conformance/packages/dns-test/src/templates/unbound.conf.jinja` (+1 -0) 📝 `crates/proto/src/rr/dnssec/rdata/rrsig.rs` (+29 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+47 -27) </details> ### 📄 Description This PR adjusts the TTL of RRSIG and its covering RR to conform to the last condition of [RFC 4035, section 5.3.3](https://datatracker.ietf.org/doc/html/rfc4035#section-5.3.3). * add tests to check conditions Closes #2292 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>