[PR #2297] [MERGED] validating recursor: return answer from cache #2932

New issue

Closed

opened 2026-03-16 11:16:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2297
Author: @japaric
Created: 7/9/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @japaric

Base: main ← Head: ja-validating-recursor-cache-lookup

📝 Commits (1)

fa2f102 validating recursor: return answer from cache

📊 Changes

1 file changed (+17 additions, -0 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+17 -0)

📄 Description

if all its records have a non-indeterminate DNSSEC state

this PR partially addresses #2294. in particular, it fully addresses this comment https://github.com/hickory-dns/hickory-dns/issues/2294#issuecomment-2214926406

we cannot really test the caching behavior with a library-level unit test because Recursor requires an initial query, which result in network operations, to cache a result.

we also cannot observe that signature validation is not repeated on a subsequent query using dns-test because the signature validation is not visible at the network level; we do have dns-test-based tests that check that no network operation happens when a query is already in the cache -- those tests were already passing without this PR.

I can, however, observe that signature validation does not happen on a second query in the hickory-dns logs

this PR depends on PR #2293 so I'm leaving it in draft state until that's merged but this PR is ready for review

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2297 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/9/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-validating-recursor-cache-lookup` --- ### 📝 Commits (1) - [`fa2f102`](https://github.com/hickory-dns/hickory-dns/commit/fa2f102b5564a01de9a7c0d85689c9d9570799d7) validating recursor: return answer from cache ### 📊 Changes **1 file changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+17 -0) </details> ### 📄 Description if all its records have a non-indeterminate DNSSEC state --- this PR partially addresses #2294. in particular, it fully addresses this comment https://github.com/hickory-dns/hickory-dns/issues/2294#issuecomment-2214926406 we cannot really test the caching behavior with a library-level unit test because `Recursor` requires an initial query, which result in network operations, to cache a result. we also cannot observe that signature validation is not repeated on a subsequent query using `dns-test` because the signature validation is not visible at the network level; we do have `dns-test`-based tests that check that no network operation happens when a query is already in the cache -- those tests were already passing without this PR. I can, however, observe that signature validation does not happen on a second query in the hickory-dns logs this PR depends on PR #2293 so I'm leaving it in draft state until that's merged but this PR is ready for review --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>