[PR #2303] [MERGED] Adjust timestamps to pass unbound validation result #2931

New issue

Closed

opened 2026-03-16 11:16:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2303
Author: @justahero
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @japaric

Base: main ← Head: adjust-timestamps-to-pass-validation-with-unbound

📝 Commits (2)

f36c7c2 Adjust timestamps to pass unbound validation
edac50f Set "val-sig-skew-min" value in unbound config

📊 Changes

2 files changed (+7 additions, -8 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_5/section_5_3.rs (+6 -8)
📝 conformance/packages/dns-test/src/templates/unbound.conf.jinja (+1 -0)

📄 Description

unbound uses a skew value (delta) to allow some leeway during validation checks to compensate situations where wall clocks between machines diverge. The default value for val-sig-skew-min is exactly 1 hour, therefore the validation to check the inception timestamp set to the future succeeded before this change instead of failing.

This updates the timestamps to pass the behavior with unbound too, removing the condition from the test.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2303 **Author:** [@justahero](https://github.com/justahero) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `adjust-timestamps-to-pass-validation-with-unbound` --- ### 📝 Commits (2) - [`f36c7c2`](https://github.com/hickory-dns/hickory-dns/commit/f36c7c235dfc90e445ffd856c88125378f61ae4e) Adjust timestamps to pass unbound validation - [`edac50f`](https://github.com/hickory-dns/hickory-dns/commit/edac50f8056a6b1322352fe71cc1a6a290c119e6) Set "val-sig-skew-min" value in unbound config ### 📊 Changes **2 files changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_5/section_5_3.rs` (+6 -8) 📝 `conformance/packages/dns-test/src/templates/unbound.conf.jinja` (+1 -0) </details> ### 📄 Description `unbound` uses a skew value (delta) to allow some leeway during validation checks to compensate situations where wall clocks between machines diverge. The default value for [`val-sig-skew-min`](https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#unbound-conf-val-sig-skew-min) is exactly 1 hour, therefore the validation to check the `inception` timestamp set to the future succeeded before this change instead of failing. This updates the timestamps to pass the behavior with `unbound` too, removing the condition from the test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>