[PR #2291] [MERGED] recursor: put tokio::test behind cfg attribute #2927

New issue

Closed

opened 2026-03-16 11:15:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:15:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2291
Author: @japaric
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @djc

Base: main ← Head: ja-gh2290

📝 Commits (1)

2e06eb4 recursor: put tokio::test behind cfg attribute

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+1 -0)

📄 Description

tokio is a dev-dependency so it's not available when building the code without --cfg test which is what cargo doc does. put the tokio test behind a #[cfg(test)] attribute to prevent the issue.

closes #2290

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2291 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ja-gh2290` --- ### 📝 Commits (1) - [`2e06eb4`](https://github.com/hickory-dns/hickory-dns/commit/2e06eb4068b0d743e8356a12bc1d2564582a2f77) recursor: put tokio::test behind cfg attribute ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+1 -0) </details> ### 📄 Description `tokio` is a dev-dependency so it's not available when building the code without `--cfg test` which is what `cargo doc` does. put the tokio test behind a `#[cfg(test)]` attribute to prevent the issue. closes #2290 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>