[PR #2281] [MERGED] Refactor `start` method in Resolver #2923

New issue

Closed

opened 2026-03-16 11:15:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:15:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2281
Author: @justahero
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/5/2024
Merged by: @japaric

Base: main ← Head: sz-refactor-resolver-start

📝 Commits (1)

d34ae9a Refactor start method in Resolver

📊 Changes

12 files changed (+32 additions, -23 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs (+5 -5)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_1.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs (+2 -2)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs (+1 -1)
📝 conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs (+1 -1)
📝 conformance/packages/dns-test/examples/explore.rs (+1 -1)
📝 conformance/packages/dns-test/src/resolver.rs (+13 -4)
📝 conformance/packages/dns-test/src/tshark.rs (+2 -2)

📄 Description

In nearly all cases the passed argument is SUBJECT, therefore the change uses this as default. A separate method start_with_subject allows to provide passing in a specific Implementation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2281 **Author:** [@justahero](https://github.com/justahero) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/5/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `sz-refactor-resolver-start` --- ### 📝 Commits (1) - [`d34ae9a`](https://github.com/hickory-dns/hickory-dns/commit/d34ae9a80f75567a6880a8d09c57c134e2c8c2a2) Refactor start method in Resolver ### 📊 Changes **12 files changed** (+32 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dns/scenarios.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/fixtures.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_1/section_3_1_4.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs` (+5 -5) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2/section_3_2_2.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_1.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_4/section_4_5.rs` (+2 -2) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/ede.rs` (+1 -1) 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/scenarios/secure.rs` (+1 -1) 📝 `conformance/packages/dns-test/examples/explore.rs` (+1 -1) 📝 `conformance/packages/dns-test/src/resolver.rs` (+13 -4) 📝 `conformance/packages/dns-test/src/tshark.rs` (+2 -2) </details> ### 📄 Description In nearly all cases the passed argument is `SUBJECT`, therefore the change uses this as default. A separate method `start_with_subject` allows to provide passing in a specific `Implementation`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>