[PR #2269] [MERGED] CI: also run hickory unit tests when only /conformance changes #2917

Closed
opened 2026-03-16 11:15:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2269
Author: @japaric
Created: 7/1/2024
Status: Merged
Merged: 7/2/2024
Merged by: @djc

Base: mainHead: ja-test-everything-all-the-time


📝 Commits (1)

  • dd798df CI: also run hickory unit tests when only /conformance changes

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 .github/workflows/test.yml (+6 -4)

📄 Description

an issue in GitHub branch protecion rules prevents us from merging PRs that only change the /conformance directory with the current CI-time saving setup.

this commit works around the issue by always running all the tests

closes #2262


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2269 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/1/2024 **Status:** ✅ Merged **Merged:** 7/2/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ja-test-everything-all-the-time` --- ### 📝 Commits (1) - [`dd798df`](https://github.com/hickory-dns/hickory-dns/commit/dd798df99565a9778d24565a236534706e793cd3) CI: also run hickory unit tests when only /conformance changes ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+6 -4) </details> ### 📄 Description an issue in GitHub branch protecion rules prevents us from merging PRs that only change the /conformance directory with the current CI-time saving setup. this commit works around the issue by *always* running all the tests closes #2262 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:15:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2917
No description provided.