[PR #2268] [MERGED] dns-test: make unit tests use the checked out version of this repo #2915

New issue

Closed

opened 2026-03-16 11:15:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:15:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2268
Author: @japaric
Created: 7/1/2024
Status: ✅ Merged
Merged: 7/2/2024
Merged by: @japaric

Base: main ← Head: ja-framework-tests-use-this-repo

📝 Commits (1)

0f361f3 dns-test: make unit tests use the checked out version of this repo

📊 Changes

3 files changed (+14 additions, -4 deletions)

View changed files

📝 conformance/packages/dns-test/src/lib.rs (+11 -0)
📝 conformance/packages/dns-test/src/name_server.rs (+1 -1)
📝 conformance/packages/dns-test/src/resolver.rs (+2 -3)

📄 Description

instead of https://github.com/hickory-dns/hickory-dns

the GitHub URL won't include the changes being tested in CI and can make the tests fail due to it being an older version

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2268 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/1/2024 **Status:** ✅ Merged **Merged:** 7/2/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-framework-tests-use-this-repo` --- ### 📝 Commits (1) - [`0f361f3`](https://github.com/hickory-dns/hickory-dns/commit/0f361f3f58250f1da6d1e4e49b9617b84e9fa6c3) dns-test: make unit tests use the checked out version of this repo ### 📊 Changes **3 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/lib.rs` (+11 -0) 📝 `conformance/packages/dns-test/src/name_server.rs` (+1 -1) 📝 `conformance/packages/dns-test/src/resolver.rs` (+2 -3) </details> ### 📄 Description instead of https://github.com/hickory-dns/hickory-dns the GitHub URL won't include the changes being tested in CI and can make the tests fail due to it being an older version --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>