[PR #2259] [MERGED] add conformance to CODEOWNERS #2913

New issue

Closed

opened 2026-03-16 11:14:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2259
Author: @japaric
Created: 6/26/2024
Status: ✅ Merged
Merged: 6/26/2024
Merged by: @djc

Base: main ← Head: ja-fix-codeowners

📝 Commits (1)

fedd4a8 add conformance to CODEOWNERS

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 .github/CODEOWNERS (+1 -0)

📄 Description

when I was working on #2222 I initially put the conformance test suite inside the tests directory but ended up moving it to the root as that simplified the changes to the justfile.

I then forgot to put that new /conformance directory in the CODEOWNERS file. this PR fixes that

thanks @justahero for spotting this

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2259 **Author:** [@japaric](https://github.com/japaric) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 6/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `ja-fix-codeowners` --- ### 📝 Commits (1) - [`fedd4a8`](https://github.com/hickory-dns/hickory-dns/commit/fedd4a8280e47cdaf4caf2d67ad8db2c08282fba) add conformance to CODEOWNERS ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/CODEOWNERS` (+1 -0) </details> ### 📄 Description when I was working on #2222 I initially put the conformance test suite inside the `tests` directory but ended up moving it to the root as that simplified the changes to the `justfile`. I then forgot to put that new `/conformance` directory in the CODEOWNERS file. this PR fixes that thanks @justahero for spotting this --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>