[PR #2247] [MERGED] improved server binary, added config validation and control over protocols #2907

New issue

Closed

opened 2026-03-16 11:14:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2247
Author: @sabify
Created: 6/17/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @djc

Base: main ← Head: bin-imprv

📝 Commits (10+)

c94fd1a improved server binary, added config validation and control over protocols
ed2cbee added appropriate feature conditioning
523b824 removed redundant server config arg description.
131fb48 consistent error messages
65f2e4a refined builder pattern
b213211 prevent compilation failure with picky tls features
975b834 extensive error handling and error messages
a7ccfa2 fix clippy warning and ci test error
d87ed60 added control over enabled protocols in server config file
d6c0159 fixed clippy nightly warning over tsig doc

📊 Changes

7 files changed (+306 additions, -179 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+254 -165)
📝 bin/tests/server_harness/mod.rs (+7 -4)
📝 conformance/packages/dns-test/src/resolver.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+5 -5)
📝 crates/proto/src/rr/dnssec/tsig.rs (+3 -3)
📝 crates/recursor/src/recursor.rs (+1 -1)
📝 crates/server/src/config/mod.rs (+35 -0)

📄 Description

...and specifying number of workers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2247 **Author:** [@sabify](https://github.com/sabify) **Created:** 6/17/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `bin-imprv` --- ### 📝 Commits (10+) - [`c94fd1a`](https://github.com/hickory-dns/hickory-dns/commit/c94fd1ae2fa7337fa64c8ee96656166bb8d8dc6b) improved server binary, added config validation and control over protocols - [`ed2cbee`](https://github.com/hickory-dns/hickory-dns/commit/ed2cbeea2740adcc8f87b3ad0a5b719f2f8b71a7) added appropriate feature conditioning - [`523b824`](https://github.com/hickory-dns/hickory-dns/commit/523b82436ad2af3e91e617c01b8fdab02d45172b) removed redundant server config arg description. - [`131fb48`](https://github.com/hickory-dns/hickory-dns/commit/131fb48e1815cd27f4e6d07e1be417f8c69539bb) consistent error messages - [`65f2e4a`](https://github.com/hickory-dns/hickory-dns/commit/65f2e4ab50230b6fa67dc4575b059b72ea89f790) refined builder pattern - [`b213211`](https://github.com/hickory-dns/hickory-dns/commit/b2132118dff2da7cc27bebd9b03250f67278496b) prevent compilation failure with picky tls features - [`975b834`](https://github.com/hickory-dns/hickory-dns/commit/975b834c8099da65f5ad5489ba5766692b4c612a) extensive error handling and error messages - [`a7ccfa2`](https://github.com/hickory-dns/hickory-dns/commit/a7ccfa28db06a509f0de1ffadf889d5e3fdebcf3) fix clippy warning and ci test error - [`d87ed60`](https://github.com/hickory-dns/hickory-dns/commit/d87ed60f904c5b5865012904438a25970b59172f) added control over enabled protocols in server config file - [`d6c0159`](https://github.com/hickory-dns/hickory-dns/commit/d6c01598c427ebad0b6361fa4c13448eb6faf483) fixed clippy nightly warning over tsig doc ### 📊 Changes **7 files changed** (+306 additions, -179 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+254 -165) 📝 `bin/tests/server_harness/mod.rs` (+7 -4) 📝 `conformance/packages/dns-test/src/resolver.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+5 -5) 📝 `crates/proto/src/rr/dnssec/tsig.rs` (+3 -3) 📝 `crates/recursor/src/recursor.rs` (+1 -1) 📝 `crates/server/src/config/mod.rs` (+35 -0) </details> ### 📄 Description ...and specifying number of workers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>