[PR #2245] [MERGED] recursor: strip dnssec records on cache hit #2901

New issue

Closed

opened 2026-03-16 11:14:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2245
Author: @japaric
Created: 6/17/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @bluejekyll

Base: main ← Head: ja-recursor-strip-dnssec-records-on-cache-hit

📝 Commits (3)

67ab728 recursor: unconditionally look into record cache
4396f42 test DO=1 query followed by DO=0 query
ecf3622 recursor: also strip DNSSEC records on cache hit

📊 Changes

2 files changed (+54 additions, -21 deletions)

View changed files

📝 conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs (+30 -0)
📝 crates/recursor/src/recursor.rs (+24 -21)

📄 Description

this is triggered by a DO=1 query followed by the almost exact same query but with DO=0

this is best reviewed on a commit by commit basis

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2245 **Author:** [@japaric](https://github.com/japaric) **Created:** 6/17/2024 **Status:** ✅ Merged **Merged:** 7/1/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `ja-recursor-strip-dnssec-records-on-cache-hit` --- ### 📝 Commits (3) - [`67ab728`](https://github.com/hickory-dns/hickory-dns/commit/67ab728732dd4380602c2683735d594e47a59f50) recursor: unconditionally look into record cache - [`4396f42`](https://github.com/hickory-dns/hickory-dns/commit/4396f4241480fa17b9470b01762cc7837148c5b1) test DO=1 query followed by DO=0 query - [`ecf3622`](https://github.com/hickory-dns/hickory-dns/commit/ecf36224f903a4a8ce7ab2502376bb4d47f850b1) recursor: also strip DNSSEC records on cache hit ### 📊 Changes **2 files changed** (+54 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs` (+30 -0) 📝 `crates/recursor/src/recursor.rs` (+24 -21) </details> ### 📄 Description this is triggered by a DO=1 query followed by the almost exact same query but with DO=0 this is best reviewed on a commit by commit basis --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>