[PR #2235] [MERGED] dns-test: make NameServer's FQDN more stable #2897

New issue

Closed

opened 2026-03-16 11:14:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:14:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2235
Author: @japaric
Created: 6/12/2024
Status: ✅ Merged
Merged: 6/14/2024
Merged by: @bluejekyll

Base: main ← Head: ja-dns-test-stabler-ns-names

📝 Commits (1)

d9d52a3 dns-test: make NameServer's FQDN more stable

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 conformance/packages/dns-test/src/name_server.rs (+4 -2)

📄 Description

previously, the FQDN of a NameServer was generated using a globally shared, monotonically increasing counter. that resulted in a unpredictable FQDN in the presence other tests running concurrently / in parallel

with this change, the presence of other test threads does not affect the FQDN automatically chosen for a NameServer. the FQDN becomes only a function of the order in which the NameServers are created within a thread

this should help write NSEC3 conformance tests cc @pvdrz

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2235 **Author:** [@japaric](https://github.com/japaric) **Created:** 6/12/2024 **Status:** ✅ Merged **Merged:** 6/14/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `ja-dns-test-stabler-ns-names` --- ### 📝 Commits (1) - [`d9d52a3`](https://github.com/hickory-dns/hickory-dns/commit/d9d52a3c67226f3415582ec773731ece8bcb23c2) dns-test: make NameServer's FQDN more stable ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/name_server.rs` (+4 -2) </details> ### 📄 Description previously, the FQDN of a NameServer was generated using a globally shared, monotonically increasing counter. that resulted in a unpredictable FQDN in the presence other tests running concurrently / in parallel with this change, the presence of other test threads does not affect the FQDN automatically chosen for a NameServer. the FQDN becomes only a function of the order in which the NameServers are created *within a thread* this should help write NSEC3 conformance tests cc @pvdrz --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>