[PR #2239] [MERGED] DnsLru: cache RRSIG records together with the record they cover #2895

Closed
opened 2026-03-16 11:14:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2239
Author: @japaric
Created: 6/14/2024
Status: Merged
Merged: 6/17/2024
Merged by: @japaric

Base: mainHead: ja-cache-rrsigs


📝 Commits (1)

  • 5acf6fc DnsLru: cache RRSIG records together with the record they cover

📊 Changes

2 files changed (+85 additions, -70 deletions)

View changed files

📝 crates/recursor/src/recursor.rs (+43 -69)
📝 crates/resolver/src/dns_lru.rs (+42 -1)

📄 Description

this simplifies the DNSSEC_OK (DO) bit handling logic in Recursor which was implemented in #2196

as a side effect Recursor will now cache queries that have the DO bit set whereas before it wasn't

this came out the work towards #2234


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2239 **Author:** [@japaric](https://github.com/japaric) **Created:** 6/14/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-cache-rrsigs` --- ### 📝 Commits (1) - [`5acf6fc`](https://github.com/hickory-dns/hickory-dns/commit/5acf6fc6126f65dc575d78280b751aa8f8bf8062) DnsLru: cache RRSIG records together with the record they cover ### 📊 Changes **2 files changed** (+85 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `crates/recursor/src/recursor.rs` (+43 -69) 📝 `crates/resolver/src/dns_lru.rs` (+42 -1) </details> ### 📄 Description this simplifies the DNSSEC_OK (DO) bit handling logic in `Recursor` which was implemented in #2196 as a side effect `Recursor` will now cache queries that have the DO bit set whereas before it wasn't this came out the work towards #2234 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:14:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2895
No description provided.