[PR #2218] [MERGED] Remove broken mtls code to fix CI #2886

New issue

Closed

opened 2026-03-16 11:13:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:13:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2218
Author: @djc
Created: 5/21/2024
Status: ✅ Merged
Merged: 5/21/2024
Merged by: @bluejekyll

Base: main ← Head: kill-mtls

📝 Commits (2)

c402372 Remove broken mtls code
8f6e4af Update dependencies

📊 Changes

11 files changed (+193 additions, -391 deletions)

View changed files

📝 Cargo.lock (+183 -188)
📝 bin/Cargo.toml (+0 -3)
📝 crates/proto/Cargo.toml (+0 -3)
📝 crates/proto/src/native_tls/tests.rs (+2 -54)
📝 crates/proto/src/native_tls/tls_client_stream.rs (+0 -8)
📝 crates/proto/src/native_tls/tls_stream.rs (+0 -6)
📝 crates/proto/src/openssl/tls_client_stream.rs (+0 -8)
📝 crates/proto/src/openssl/tls_stream.rs (+0 -6)
📝 crates/proto/src/rustls/tests.rs (+4 -52)
📝 crates/proto/tests/openssl_tests.rs (+4 -60)
📝 crates/server/Cargo.toml (+0 -3)

📄 Description

Nightly Rust started warning about undefined features, which broke CI:

https://github.com/hickory-dns/hickory-dns/actions/runs/9172380557/job/25219060007

The mtls feature seems to have been added in a broken state in #117 and has never since been fixed. I wouldn't be surprised if the same use case can work today by providing a preconfigured rustls ClientConfig with client authentication enabled. In either case, it seems unlikely that this code will ever be fixed, so probably better to remove it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2218 **Author:** [@djc](https://github.com/djc) **Created:** 5/21/2024 **Status:** ✅ Merged **Merged:** 5/21/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `kill-mtls` --- ### 📝 Commits (2) - [`c402372`](https://github.com/hickory-dns/hickory-dns/commit/c4023725973f2cc18adba3e10ec52a97831ef1e7) Remove broken mtls code - [`8f6e4af`](https://github.com/hickory-dns/hickory-dns/commit/8f6e4afb71c59c10f4baf4cb162dd5629878d29c) Update dependencies ### 📊 Changes **11 files changed** (+193 additions, -391 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+183 -188) 📝 `bin/Cargo.toml` (+0 -3) 📝 `crates/proto/Cargo.toml` (+0 -3) 📝 `crates/proto/src/native_tls/tests.rs` (+2 -54) 📝 `crates/proto/src/native_tls/tls_client_stream.rs` (+0 -8) 📝 `crates/proto/src/native_tls/tls_stream.rs` (+0 -6) 📝 `crates/proto/src/openssl/tls_client_stream.rs` (+0 -8) 📝 `crates/proto/src/openssl/tls_stream.rs` (+0 -6) 📝 `crates/proto/src/rustls/tests.rs` (+4 -52) 📝 `crates/proto/tests/openssl_tests.rs` (+4 -60) 📝 `crates/server/Cargo.toml` (+0 -3) </details> ### 📄 Description Nightly Rust started warning about undefined features, which broke CI: https://github.com/hickory-dns/hickory-dns/actions/runs/9172380557/job/25219060007 The `mtls` feature seems to have been added in a broken state in #117 and has never since been fixed. I wouldn't be surprised if the same use case can work today by providing a preconfigured rustls `ClientConfig` with client authentication enabled. In either case, it seems unlikely that this code will ever be fixed, so probably better to remove it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>